feat: reduce boilerplate logic for importing fs module #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Pollind <mpollind@gmail.com>
pollend
force-pushed
the
feature/reduce-boilderplate-logic-when-importing-modules
branch
from
2f1bc87
to
c4938f0
Compare
Signed-off-by: Michael Pollind <mpollind@gmail.com>
pollend
commented
Feb 19, 2024
Comment on lines
+44
to
+51
| #define Mod_Mem_AllocExt( pool, size, align, value ) _Mod_Mem_AllocExt( pool, size, align, value, __FILE__, __LINE__ ) | ||
| #define Mod_Mem_Alloc( pool, size ) _Mod_Mem_Alloc( pool, size, __FILE__, __LINE__ ) | ||
| #define Mod_Mem_Realloc( data, size ) _Mem_Realloc( data, size, __FILE__, __LINE__ ) | ||
| #define Mod_Mem_Free( mem ) _Mod_Free( mem, __FILE__, __LINE__ ) | ||
| #define Mod_Mem_AllocPool( parent, name ) _Mod_AllocPool( parent, name, __FILE__, __LINE__ ) | ||
| #define Mod_Mem_FreePool( pool ) _Mod_Mem_FreePool( pool, __FILE__, __LINE__ ) | ||
| #define Mod_Mem_EmptyPool( pool ) _Mem_EmptyPool( pool, __FILE__, __LINE__ ) | ||
| #define Mod_Mem_CopyString( pool, str ) _Mem_CopyString( pool, str, __FILE__, __LINE__ ) |
There was a problem hiding this comment.
is there a better way to name this ?
Signed-off-by: Michael Pollind <mpollind@gmail.com>
Signed-off-by: Michael Pollind <mpollind@gmail.com>
pollend
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.