P2P game networking through Steam Datagram Relay #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Pollind <mpollind@gmail.com>
Signed-off-by: Michael Pollind <mpollind@gmail.com>
Signed-off-by: Michael Pollind <mpollind@gmail.com>
Signed-off-by: Michael Pollind <mpollind@gmail.com>
Signed-off-by: Michael Pollind <mpollind@gmail.com>
Signed-off-by: Michael Pollind <mpollind@gmail.com>
Signed-off-by: Michael Pollind <mpollind@gmail.com>
Signed-off-by: Michael Pollind <mpollind@gmail.com>
Signed-off-by: Michael Pollind <mpollind@gmail.com>
Signed-off-by: Michael Pollind <mpollind@gmail.com>
Signed-off-by: Michael Pollind <mpollind@gmail.com>
Signed-off-by: Michael Pollind <mpollind@gmail.com>
Signed-off-by: Michael Pollind <mpollind@gmail.com>
Signed-off-by: Michael Pollind <mpollind@gmail.com>
Signed-off-by: Michael Pollind <mpollind@gmail.com>
pollend
reviewed
Oct 7, 2024
Comment on lines
+1148
to
+1151
| int i, num_max; | ||
| unsigned line_height; | ||
| int xoffset, yoffset = 0; | ||
| struct shader_s *pic; |
There was a problem hiding this comment.
do we need to reuse variables?
pollend
reviewed
Oct 7, 2024
Comment on lines
+178
to
+211
| static void SV_P2P_NewConnection( void *self, struct steam_evt_pkt_s *evt ) | ||
| { | ||
| struct p2p_new_connection_evt_s *p2p = &evt->p2p_new_connection; | ||
|
|
||
| // find a free slot | ||
| int free = -1; | ||
| for( int i = 0; i < MAX_INCOMING_CONNECTIONS; i++ ) { | ||
| if( !svs.incomingp2p[i].active ) { | ||
| free = i; | ||
| break; | ||
| } | ||
| } | ||
| if( free == -1 ) { | ||
| Com_Printf( "No free slot for P2P connection\n" ); | ||
| return; | ||
| } | ||
| printf("New %i P2P connection from %llu\n", free, p2p->steamID); | ||
|
|
||
| incoming_t *inc = &svs.incomingp2p[free]; | ||
| netadr_t address; | ||
| NET_InitAddress( &address, NA_SDR ); | ||
| address.address.steamid = p2p->steamID; | ||
|
|
||
| inc->active = true; | ||
| inc->time = svs.realtime; | ||
| inc->address = address; | ||
|
|
||
| inc->socket.address = address; | ||
| inc->socket.type = SOCKET_SDR; | ||
| inc->socket.handle = p2p->handle; | ||
| inc->socket.server = true; | ||
| inc->socket.open = true; | ||
| inc->socket.connected = true; | ||
| } |
There was a problem hiding this comment.
nit: fomatting is a bit funny. maybe change it to all to space or tabs looks.
pollend
reviewed
Oct 7, 2024
Comment on lines
+12
to
+13
| template <typename T> | ||
| static inline void write_packet( PipeType fd, const T *response, uint32_t size ) |
There was a problem hiding this comment.
The template might not be necessary? can you use a void pointer the type is not used for the body of the function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.