Added bestiary lore from mainhand #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
run /bestiary lore frommainhand <mobname> to copy the lore from your mainhand onto the mob's lore. 90% of this change is just refactoring everything to be components rather than strings
U5B
approved these changes
Mar 4, 2024
backwards compatibility for already existing lore strings in the file
NickNackGus
reviewed
Mar 7, 2024
| @@ -16,6 +16,7 @@ | |||
| import java.util.ArrayList; | |||
| import java.util.List; | |||
| import net.kyori.adventure.text.Component; | |||
| import net.kyori.adventure.text.TextComponent; | |||
There was a problem hiding this comment.
I don't know why the review dog isn't properly reporting these anymore - this unused import needs to be removed.
Combustible
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run /bestiary lore frommainhand to copy the lore from your mainhand onto the mob's lore. 90% of this change is just refactoring everything to be components rather than strings.