-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'Show info' does not show info. #2366
Comments
Could not replicate. |
I experienced the same issue.
Result:
If I tap "Video player" instead of "Show info", pressing the Android back button returns to the previous app, not the info page. Moto G5 Plus, Android 7.0, Newpipe 0.16.2 (F-Droid?). |
I made a request to remove the Just Once & Always Buttons since it causes confusion and if you press Always by accident then you have to set it back to Always Ask in the settings again. I do not think it is a big fix since all that is needed is to remove a button and rename the Just Once button to OK. |
I was unable to reproduce this issue in the debug app, even when replacing /data/data with the release version and renaming "shared_prefs/org.schabi.newpipe_preferences.xml". I ended up building the release app in Android Studio, overwriting my actual release app (made possible by Lucky Patcher, actually a huge security vulnerability that I forgot to disable this mode), and throwing exceptions in the source code to analyze the stack traces and diagnose the issue. NewPipe/app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.java Lines 1159 to 1160 in f98e5cc
#2232 "Re-add ability to autoplay video when directly opened" claims that this feature (reported as a bug in this issue) has been removed. NewPipe/app/src/main/java/org/schabi/newpipe/util/NavigationHelper.java Lines 497 to 499 in 21a90bb
It was not removed, but the preference entry to turn it on/off was removed from the GUI, while keeping the choice made in an earlier version of the app! As a result, this invisible config entry causes some older app installations to either exhibit this issue's behavior or not, without any visible configuration differences. Both 0.16.2 and dev 6a0450b exhibit this hidden state behavior. I suggest either adding this checkbox back to the GUI, or unconditionally setting |
So, still open? |
Clear app data to avoid this issue. |
Out of scope after #2907: the autoplay toggle now exists again |
'Show info' does not show info but loads the video directly.
From all places where it appears (ie. from Downloads context menu, from What's new, etc.).
This is destructive when one has a limited dataplan.
Android 6
Huawei P8 Lite
The text was updated successfully, but these errors were encountered: