Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Show info' does not show info. #2366

Closed
NitroNils opened this issue May 28, 2019 · 7 comments
Closed

'Show info' does not show info. #2366

NitroNils opened this issue May 28, 2019 · 7 comments
Labels
bug Issue is related to a bug good first issue Easy/simple issues perfect for newcomers to get involved in the project

Comments

@NitroNils
Copy link

'Show info' does not show info but loads the video directly.
From all places where it appears (ie. from Downloads context menu, from What's new, etc.).

This is destructive when one has a limited dataplan.

Android 6
Huawei P8 Lite

android:versionCode="730" android:versionName="0.16.1" android:compileSdkVersion="28" android:compileSdkVersionCodename="9" package="org.schabi.newpipe" platformBuildVersionCode="730" platformBuildVersionName="0.16.1">
<uses-sdk android:minSdkVersion="19" android:targetSdkVersion="28"/>
@gkeegan
Copy link
Contributor

gkeegan commented May 28, 2019

Could not replicate.

@nyanpasu64
Copy link
Contributor

I experienced the same issue.

  • Use an external app and tap a Youtube link
  • Open it via Newpipe
  • (Prefered 'open' action = Always ask)
  • I tap "Show info", JUST ONCE.

Result:

  • The video player pops up. Pressing Android back button goes to the video info page.

If I tap "Video player" instead of "Show info", pressing the Android back button returns to the previous app, not the info page.

Moto G5 Plus, Android 7.0, Newpipe 0.16.2 (F-Droid?).

@trymeouteh
Copy link

trymeouteh commented Jul 15, 2019

I made a request to remove the Just Once & Always Buttons since it causes confusion and if you press Always by accident then you have to set it back to Always Ask in the settings again. I do not think it is a big fix since all that is needed is to remove a button and rename the Just Once button to OK.

#2172

@nyanpasu64
Copy link
Contributor

nyanpasu64 commented Aug 17, 2019

I was unable to reproduce this issue in the debug app, even when replacing /data/data with the release version and renaming "shared_prefs/org.schabi.newpipe_preferences.xml".

I ended up building the release app in Android Studio, overwriting my actual release app (made possible by Lucky Patcher, actually a huge security vulnerability that I forgot to disable this mode), and throwing exceptions in the source code to analyze the stack traces and diagnose the issue.


if (autoPlayEnabled) {
openVideoPlayer();

#2232 "Re-add ability to autoplay video when directly opened" claims that this feature (reported as a bug in this issue) has been removed.

rIntent.putExtra(VideoDetailFragment.AUTO_PLAY,
PreferenceManager.getDefaultSharedPreferences(context)
.getBoolean(context.getString(R.string.autoplay_through_intent_key), false));

It was not removed, but the preference entry to turn it on/off was removed from the GUI, while keeping the choice made in an earlier version of the app!

As a result, this invisible config entry causes some older app installations to either exhibit this issue's behavior or not, without any visible configuration differences.

Both 0.16.2 and dev 6a0450b exhibit this hidden state behavior.


I suggest either adding this checkbox back to the GUI, or unconditionally setting autoplay to false.

@Stypox Stypox added bug Issue is related to a bug good first issue Easy/simple issues perfect for newcomers to get involved in the project labels Sep 29, 2019
@NitroNils
Copy link
Author

So, still open?

@nyanpasu64
Copy link
Contributor

Clear app data to avoid this issue.

@Stypox
Copy link
Member

Stypox commented Aug 4, 2020

Out of scope after #2907: the autoplay toggle now exists again

@Stypox Stypox closed this as completed Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug good first issue Easy/simple issues perfect for newcomers to get involved in the project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants