Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completely remove autoplay preference (now always false) #3771

Closed
wants to merge 1 commit into from

Conversation

Stypox
Copy link
Member

@Stypox Stypox commented Jun 10, 2020

What is it?

  • Bug fix (user facing)
  • Feature (user facing)
  • Code base improvement (dev facing)
  • Meta improvement to the project (dev facing)

Fixes the following issue(s)

Completes the removal of the autoplay feature. Fixes #2366 and also closes #2232 since this is the chosen UX. Thanks to @nyanpasu64 for the investigation.

Agreement

@nyanpasu64
Copy link
Contributor

Not a member of this project, but would it be a good idea to rip out VideoDetailFragment.AUTO_PLAY and related function parameters altogether?

@Stypox
Copy link
Member Author

Stypox commented Jun 10, 2020

Who knows if they will ever be useful again in the future

@Stypox
Copy link
Member Author

Stypox commented Aug 4, 2020

This is used, after #2907

@Stypox Stypox closed this Aug 4, 2020
@Stypox Stypox deleted the remove-autoplay branch August 4, 2020 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Show info' does not show info. Re-add ability to autoplay video when directly opened
2 participants