Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscriptions and saved playlist swapped #2995

Closed
3 tasks done
milklineep opened this issue Jan 24, 2020 · 5 comments
Closed
3 tasks done

Subscriptions and saved playlist swapped #2995

milklineep opened this issue Jan 24, 2020 · 5 comments
Labels
bug Issue is related to a bug GUI Issue is related to the graphical user interface

Comments

@milklineep
Copy link

In the latest 0.18.2 hotfix, the "subscriptions" and "saved playlist" tabs are swapped atound: the subscription tab has the name and icon of the playlists tab and vice versa. See screenshots.
I think that the contents got swapped as I remember having the subscriptions list directly on the left of the subscription feed for easier access in 0.18.0. I think this was also a bug in 0.18.1 RC1 but I don't have enough space to install it again.

20200124_133439
20200124_133552

@Stypox
Copy link
Member

Stypox commented Jan 24, 2020

This might be related to #2871. @atpamat could you take a look into it?

@Stypox Stypox added bug Issue is related to a bug GUI Issue is related to the graphical user interface labels Jan 24, 2020
@B0pol
Copy link
Member

B0pol commented Jan 24, 2020

I already encountered this issue.
And yeah, this is #2871 related, as it let us custom main page tabs.

How I have to reproduce (100% reproduceable):

  1. Custom your main page, for example swap trending and subscriptions.
  2. Export your data.
  3. Uninstall your app.
  4. Install NewPipe again.
  5. Look at main page. You have default look.
  6. Import your data.
  7. Go back to the main page, you will see the wrong tab displayed: The title and icon are as it should be, but the content isn't.

If you wanna reproduce again, you can skip steps 1 and 2 if you already have a backup file with tabs customised

Workaround: just reload the app once and it will never happen again (unless you uninstall and reinstall)

I guess you were on F-Droid, updated to v0.18.2 from Github, and therefore had to uninstall because of different signatures?

@atpamat
Copy link
Contributor

atpamat commented Jan 24, 2020

I don't think it's related to #2871 as the issue persists after I reversed the commit.

Also it's enough to clear storage instead of reinstalling the app while reproducing.

EDIT: I checked a few past releases and the issue seems to have been introduced in version 0.18.0.

@milklineep
Copy link
Author

milklineep commented Jan 24, 2020 via email

@Stypox
Copy link
Member

Stypox commented May 22, 2020

From the reproduction steps explained by @B0pol it seems like #3312 is duplicate

@Stypox Stypox closed this as completed May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug GUI Issue is related to the graphical user interface
Projects
None yet
Development

No branches or pull requests

4 participants