Main page tabs aren't what they should be after import before restart

[PeterHindes]

Imported data is only updated after restart of NewPipe.
After importing data from an older version with a different tab arrangement, the taps will not contain the screen they should. Haven't tested with data from the current version. Fix is simple. Close the app and relaunch after importing. The app can do this its self to prevent user jank.

Different tab arrangement:

[mauriciocolli]

I'm not able to replicate this, can you post more detailed steps to reproduce it like the bug report template indicates?

[PeterHindes]

Sorry about that.
Steps

1. Install older version of newpipe
2. Use settings to change which tabs show on top
3. Export settings from old version of newpipe
4. Install newest newpipe.
5. import settings
6. return to the home screen and see that they are not what the icon says they are. Unitll
7. Restart the app
8. They behave normaly now.

[gkeegan]

I have noticed odd behavior with the import as well when changing the tabs. Can confirm this is (or at least was, but I don't see commits that say it was fixed) a bug.

[PeterHindes]

I tested it on a build of the code from the dev branch

[PeterHindes]

Should be a simple fix to restart the app on import of settings.

[mauriciocolli]

@PeterHindes

You can see in this absolute bad practice of a class that the app is, indeed, restarted. In my case, the app is restarted and all the tabs are what they should be, in various Android versions as well.

About that screenshot that you posted, the name and the icon match what it should be. Please, post screenshots before and after importing so we can see the difference.

But by what you just said above:

Should be a simple fix to restart the app on import of settings.

And,

5. import settings
6. return to the home screen and see that they are not what the icon says they are. Unitll

Most probably the app is not restarting due to something specific to your device, you shouldn't be able to just return to the home screen.

Is that it? The app doesn't restart at all after confirming the two dialogs?

---

@gkeegan

Can confirm this is (or at least was, but I don't see commits that say it was fixed) a bug.

Please, post the before/after screenshots too. And does the app restart at all for you?

[gkeegan]

I can't do screenshots since I'm on 0.19.0 and afraid to import data since it is apparently broken or something. What I remember is that it shows trending when it is supposed to be the channel list with the "whats new" bar at the top. What was supposed to be bookmarks because that page instead.

[gkeegan]

It did restart when I did it yes.

[PeterHindes]

I am running it in the android emulator on andorid r and on a oneplus 6t on android 10

[PeterHindes]

Ill try to collect screen shots in a little while

[mauriciocolli]

Oh, now I managed to replicate the bug. Will fix it shortly.

[opusforlife2]

Still true as of 0.19.8.

[opusforlife2]

Some (accidental?) progress on this: If you uninstall an APK, reinstall it, then import database, Newpipe immediately shows the correct main page tabs, and also shows a toast saying the language will be changed on app restart (if that setting has been changed from the default).

But for some reason, this does not happen for completely new APKs.

@PeterHindes Could you confirm if this is the case for you?

[PeterHindes]

Some (accidental?) progress on this: If you uninstall an APK, reinstall it, then import database, Newpipe immediately shows the correct main page tabs, and also shows a toast saying the language will be changed on app restart (if that setting has been changed from the default).

But for some reason, this does not happen for completely new APKs.

@PeterHindes Could you confirm if this is the case for you?

I don't have the original testing environment I was using. Sorry.

[opusforlife2]

@PeterHindes Sorry, I didn't get it. What testing environment? To be clear, I'm talking about the current release of Newpipe.

[PeterHindes]

@PeterHindes Sorry, I didn't get it. What testing environment? To be clear, I'm talking about the current release of Newpipe.

I installed a different rom on my phone and haven't been using NewPipe. I don't have my old save data.

[opusforlife2]

I just installed a brand new debug APK (from #6673), and it was able to successfully import the database and run on the first try. Seems like this problem is fixed. I want to test one or two more new debug APKs before closing this, though.

[XiangRongLin]

It's probably because of #6639.

Now the db is closed before the import and gets reopened on the new db.

[opusforlife2]

This was actually fixed by #6639, but that's already merged, so I linked it to the Release PR instead.

[opusforlife2]

Actually, fixed by #6495 in a previous release. Closing.