-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade some dependencies #3509
Conversation
Have you tested on 4.4? |
@Stypox: Not thoroughly, but I was going to. |
Reading licenses is broken :/ Edit: I partially fixed that, however it shows nothing on my phone as soon as I add any stylesheet. It currently works on an Android 4.4 AVD though, which was crashing before, but I didn't test it in any other AVDs yet. Edit 2: the issue on my phone doesn't happen when reverting compile/targetSdkVersion to 28. Ughhh… Edit 3: it happens in an Android 10 AVD as well, so at least it's not some Samsung bullshit. Edit 4: it apparently needs to be base64-encoded since Android 10, so I did that now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code seems correct to me.
I tested on AVD API 19 and AVD Android 10, I have hopefully gone through many of the processes that involve the library updates and everything seems to work just fine (@TobiGr is there a protocol that can be followed to fully test such app-wide changes?).
The new "Leaks" icon is adorable ;-)
app/src/main/java/org/schabi/newpipe/about/LicenseFragmentHelper.java
Outdated
Show resolved
Hide resolved
@Stypox Test everything on KitKat, Lollipop, latest and a version (maybe Oreo) in between. With so many upgraded dependencies almost everything is somehow affected by this change. |
@TobiGr: I think he meant more like what is "everything"? NewPipe has so many features that you could easily forget one. |
Btw I also tested on my 7.0 phone and everything works fine |
Tested on 9.0 phone and Android TV 7.1.2 and I haven't found an issue. |
I tested it on AVD API 19 and on my phone with Android 10. I'll rebase and do what @Stypox suggested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
app/src/main/java/org/schabi/newpipe/about/LicenseFragmentHelper.java
Outdated
Show resolved
Hide resolved
On KitKat main page tabs are not loaded again when new tabs are added through the settings. |
@TobiGr: I just rebased, but I can't reproduce your bug. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is it?
Agreement