Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.19.4 #3670

Closed
Stypox opened this issue May 29, 2020 · 15 comments
Closed

Release 0.19.4 #3670

Stypox opened this issue May 29, 2020 · 15 comments
Milestone

Comments

@Stypox
Copy link
Member

Stypox commented May 29, 2020

Changelog

App

New

Improved

Fixed

Development

Extractor

New

Improved

Fixed

Development


APK for testing

app-debug_RC2.zip

Corresponding pull request: #3669

PLEASE REPORT ONLY NEW BUGS BELOW

@dontfizwhataintbroke
Copy link

Can I overwrite my newpipe version with this

@Stypox
Copy link
Member Author

Stypox commented May 29, 2020

@dontfizwhataintbroke Currently no, wait for the release to be released ;-)

@dontfizwhataintbroke
Copy link

@dontfizwhataintbroke Currently no, wait for the release to be released ;-)

Ok, video playback in popup working much better and I have not faced the "Could not parse website" yet.

Many thanks for swift response and actions

@Abdel-ilah
Copy link

Release 0.19.4 - download video test.

Error: The destination folder can not be created
Mi 9, Android 10

@Stypox
Copy link
Member Author

Stypox commented May 29, 2020

@Abdel-ilah is this a new issue? Also, since you are on Android 10 you should enable the "Use SAF" setting in Download, I'm not sure if the old & deprecated method works on the newest Android.

@wb9688
Copy link
Contributor

wb9688 commented May 29, 2020

@Stypox: On newer versions, SAF is only necessary for external storage (i.e. SD cards, or e.g. USB sticks you attach through OTG). On even newer versions, SAF doesn't allow giving an app permission to read /sdcard/ (which to be clear is your internal storage) directly, but only subdirectories. Also, the way we tell the system to recognize a download as media is deprecated now.

@Abdel-ilah
Copy link

@Abdel-ilah is this a new issue? Also, since you are on Android 10 you should enable the "Use SAF" setting in Download, I'm not sure if the old & deprecated method works on the newest Android.

I faced this issue in the previous version when i upgraded to 29 API level (Android 10) and resolved after down to 28 API

@opusforlife2
Copy link
Collaborator

The brightness and volume gesture icons have become hilariously tiny, like baby versions of themselves.

@Stypox
Copy link
Member Author

Stypox commented May 29, 2020

Is this ok @opusforlife2 @HugeFrog24 ?

@opusforlife2
Copy link
Collaborator

@Stypox Yup.

@Stypox
Copy link
Member Author

Stypox commented May 29, 2020

@opusforlife2 @HugeFrog24 here is RC2: app-debug_RC2.zip

@vrhikaru
Copy link

all Youtube video open failed.

Caused by: org.schabi.newpipe.extractor.utils.Parser$RegexException: failed to find pattern ";([A-Za-z0-9_$]{2})...( inside of var mea=function(a){a=a.split("");var b=[function(c,d){d=(d%c.length+c.length)%c.length;c.splice(d,1)};"

@wb9688
Copy link
Contributor

wb9688 commented May 29, 2020

@vrhikaru: Do you have the same issue with https://wb9688.stackstorage.com/s/bekYrunPaZ7Yff4? If so, could you manually give it storage permission in Android's settings and give me the initialAjax*.json it outputs in /sdcard/?

@tuxayo
Copy link

tuxayo commented May 29, 2020

No issues on RC2 after a quick test. 🎉 Thanks for your work all.

@TobiGr
Copy link
Contributor

TobiGr commented May 29, 2020

I reverted the regex function updates which might have caused @vrhikaru's problem. No new RC, I'll release the update shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants