Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open in browser button now really opens in browser #3501

Merged
merged 3 commits into from
May 21, 2020

Conversation

B0pol
Copy link
Member

@B0pol B0pol commented Apr 29, 2020

What is it?

  • Bug fix (user facing)
  • Feature (user facing)
  • Code base improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Open in browser buttons open in default browser for android 6+ (otherwise no change).

Fixes the following issue(s)

  • Open in browser button not opening in browser, but either showing a chooser, or worse: opening in NewPipe if NewPipe is set as default for youtube links. I just wanna open in browser

It will only work for android 6+ since it uses default apps, available from settings -> apps -> more -> default apps -> browser app, a new feature in android 6, otherwise it will not change. It will also not change if you have no browser set as default. It's a rare case, because if you have only one browser that does not happen, if you have two, as soon as you choose one browser as default for opening a link, it will be set default in that selector.
Therefore there are only two such cases: fresh new browser install, or not any link set as default.

I've tested with Firefox, Firefox preview and a chromium based browser and had no troubles with this code (I first had a problem with Firefox browsers but changed the way to send the intent, following playWithKore() and now it works).

Testing apk

NewPipe_openInBrowser.zip

Agreement

@B0pol B0pol added the bug Issue is related to a bug label Apr 29, 2020
@B0pol B0pol requested a review from Stypox May 19, 2020 20:03
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :-D

@B0pol B0pol merged commit a3e2a08 into TeamNewPipe:dev May 21, 2020
@B0pol B0pol deleted the openInBrowser branch May 21, 2020 07:25
@TobiGr TobiGr added this to the 0.19.4 milestone May 21, 2020
@TobiGr
Copy link
Contributor

TobiGr commented May 21, 2020

@B0pol When merging PRs, please add them to the release notes.

@Younes-L
Copy link

Younes-L commented May 29, 2020

(Edited) could not reproduce this issue in 0.19.3, no matter how many YouTube links I set as default for newpipe

@B0pol
Copy link
Member Author

B0pol commented May 30, 2020

The fix comes in version 0.19.4

@Younes-L
Copy link

The fix comes in version 0.19.4

I only originally commented thinking the behaviour change affects me, but after more testing it seemed to not affect my usecase.

To find out what actually changed, I tried to reproduce the problem using 0.19.3 and compare the results with 0.19.4, but saw no difference.
Using 0.19.3, I was unable to have newpipe open videos with the "open in browser" button.
(Could not reproduce this issue : "worse: opening in NewPipe if NewPipe is set as default for youtube links.")
I set newpipe 0.19.3 as default for www.youtube , m.youtube, youtu.be , and channel links.
Excuse my confusing comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants