-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open in browser button now really opens in browser #3501
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :-D
@B0pol When merging PRs, please add them to the release notes. |
(Edited) could not reproduce this issue in 0.19.3, no matter how many YouTube links I set as default for newpipe |
The fix comes in version 0.19.4 |
I only originally commented thinking the behaviour change affects me, but after more testing it seemed to not affect my usecase. To find out what actually changed, I tried to reproduce the problem using 0.19.3 and compare the results with 0.19.4, but saw no difference. |
What is it?
Description of the changes in your PR
Fixes the following issue(s)
It will only work for android 6+ since it uses default apps, available from settings -> apps -> more -> default apps -> browser app, a new feature in android 6, otherwise it will not change. It will also not change if you have no browser set as default. It's a rare case, because if you have only one browser that does not happen, if you have two, as soon as you choose one browser as default for opening a link, it will be set default in that selector.
Therefore there are only two such cases: fresh new browser install, or not any link set as default.
I've tested with Firefox, Firefox preview and a chromium based browser and had no troubles with this code (I first had a problem with Firefox browsers but changed the way to send the intent, following playWithKore() and now it works).
Testing apk
NewPipe_openInBrowser.zip
Agreement