Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ktlint #3511

Merged
merged 3 commits into from
May 4, 2020
Merged

Ktlint #3511

merged 3 commits into from
May 4, 2020

Conversation

wb9688
Copy link
Contributor

@wb9688 wb9688 commented May 1, 2020

What is it?

  • Bug fix (user facing)
  • Feature (user facing)
  • Code base improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Add Ktlint, which is a linter for Kotlin. It has a built-in formatter, so that's nice. The only thing I don't like about it is that it doesn't have a config file, but is only kinda configurable by creating extensions, though I don't think we need some non-default configuration.

Agreement

@wb9688 wb9688 added the meta Related to the project but not strictly to code label May 1, 2020
@wb9688 wb9688 added this to the 0.19.4 milestone May 1, 2020
@wb9688 wb9688 merged commit b630f26 into TeamNewPipe:dev May 4, 2020
This was referenced May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Related to the project but not strictly to code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants