Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change retry & subscribe buttons background color based on service color #3565

Merged
merged 2 commits into from
May 13, 2020
Merged

Change retry & subscribe buttons background color based on service color #3565

merged 2 commits into from
May 13, 2020

Conversation

B0pol
Copy link
Member

@B0pol B0pol commented May 10, 2020 •
edited by Stypox
Loading

What is it?

  • Bug fix (user facing)
  • Feature (user facing)
  • Code base improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • change retry (when there is a network error) button color, to follow service's color

Fixes the following issue(s)

Testing apk

app-debug.zip

Screenshots

Agreement

@B0pol B0pol added feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface labels May 10, 2020
@B0pol B0pol added this to the 0.19.4 milestone May 10, 2020
@Stypox
Copy link
Member

Stypox commented May 10, 2020 •
edited
Loading

I guess this is already done by #3482 (will test in a bit and report back) not true

@Stypox
Copy link
Member

Stypox commented May 11, 2020

Is RedButton used anywhere else? If that's not the case it could be removed

@B0pol
Copy link
Member Author

B0pol commented May 11, 2020

It's used for subscribe button

@Stypox
Copy link
Member

Stypox commented May 11, 2020

Can't the subscribe button also be changed? Its red background looks a little bit strage on platforms other than youtube, and in material guidelines buttons usually have the primary color (go here and search for A contained button has a text label, a filled container and an optional icon.. In the section below the background color of the button in ?attr/colorPrimary).

@B0pol B0pol changed the title Change retry button background color based on service color Change retry & subscribe buttons background color based on service color May 11, 2020
@B0pol
Copy link
Member Author

B0pol commented May 11, 2020

Done @Stypox

@B0pol B0pol requested a review from Stypox May 12, 2020 23:47
Stypox
Stypox approved these changes May 13, 2020
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and everything works fine after some testing :-D

@Stypox Stypox merged commit 6dc7dab into TeamNewPipe:dev May 13, 2020
@B0pol B0pol deleted the retry-button-color branch May 13, 2020 09:04
This was referenced May 29, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stypox Stypox Stypox approved these changes

Assignees
No one assigned
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface
Projects
None yet
Milestone
0.19.4
Development

Successfully merging this pull request may close these issues.

Different colors of "Retry" button and services
2 participants
@B0pol @Stypox