-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "System default" theme option. #3420
Comments
+1 |
@xmha97 To show agreement you give a thumbs up on the top comment, not add another comment. |
I am on Android 10 and yes, if you slect dark mode to turn on at X time all apps will switch to dark theme if they support it. It is really annoying to not have this feature. |
I'm just dropping in to say that I would also greatly appreciate this feature being added, as it would improve the integration with the android system, and would thus be a welcome change for me. Thanks for all the work you've put into this wonderful app! |
Will this be added or something or why was it closed, @Redirion ? |
Yes as PR #3632 added this option. It will be part of the next NewPipe version |
@LongJohn-Silver "X closed this in #abcd" means that issue was closed by a linked PR which fixes the bug/implements the feature request. |
@opusforlife2 Sorry I am using a third party client which did not show all the details. |
Describe the feature you want
I would like NewPipe theme to follow Android theme
Is your feature request related to a problem? Please describe it
If I change Android theme, it won't change NewPipe theme.
Additional context
How will you/everyone benefit from this feature?
It will need less effort to change theme of my apps (apps without system theme option, including NewPipe).
It would also fix #1535 for people who can set a system-wide theme settings (Correct me if I'm wrong, Android 10+ users, LineageOS 16 (and custom ROMs based on Lineage 16), and other custom ROMs implementing system-wide theme settings).
The text was updated successfully, but these errors were encountered: