Add settings to match device's theme (dark & black)

[B0pol]

What is it?

• Bug fix (user facing)
• Feature (user facing)
• Code base improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

Added two device theme settings:

• Device theme (Dark)
• Device theme (Black)

Device theme (Dark) and Device theme (Black) will set the theme to light if device's theme is light or unknown, otherwise it will set dark or black.

Available for Android 10+ only, LineageOS 16+ and other ROMs providing dark theme.

Here is a GIF:

Fixes the following issue(s)

• Fixes Add "System default" theme option. #3420
• Fixes Add full black theme. #687
• Fixes partially DayNight Mode #1535 : fixes for people who can set Automatic (time of the day) theme in Android settings.

Testing apk

NewPipe_theme.zip

Agreement

• I carefully read the contribution guidelines and agree to them.

[B0pol]

I've rebased and fixed a bug around isLightThemeSelected.

[TobiGr]

Nice 👍

[wb9688]

Imho we should hide the follow system theme options when the user's Android version doesn't support that.

[B0pol]

Imho we should hide the follow system theme options when the user's Android version doesn't support that.

I won't hide it for android 9 because of LineageOS supporting themes anyway. And SAF settings was doing this for a long time

[wb9688]

Other than this small thing, I would merge this.

[Stypox]

^{From @B0pol accidentally posted in #3471 (comment)}
I rebased and used a switch preference instead of "follow … (theme 1)" "follow … (theme 2)"

[wb9688]

@B0pol: Your switch preference is flawed, because then it won't actually follow device theme when you've selected the light theme.

[B0pol]

@B0pol: Your switch preference is flawed, because then it won't actually follow device theme when you've selected the light theme.

that's intended. With what would you switch? Dark or black? If we had only dark and light I'd have make a simple third theme: auto. The point is to select between dark and black here

[wb9688]

@B0pol: Yes, but why is it showing the light option when you could only choose between dark and black for the follow device theme functionality? I still prefer your previous UI though.

[TobiGr]

I agree with @wb9688. What about replacing the switch with a list

Follow device theme
May not work on Android 9 and below. Device theme ignored.
May not work on Android 9 and below. Use (dark|black) theme on device's night mode.

[opusforlife2]

When the follow system theme toggle is switched on, the light theme should be greyed out so only the dark and black options are selectable. That's what I had suggested previously.

[B0pol]

I have another idea:

• light
• dark
• black
• [maybe? Terminal theme]
• automatic (system)
• [in the future] automatic (battery saver)
• [in the future] automatic (day / night)

And after that two other lists
[In the future, if it exists)

• light 1
• light and cool 2

The second list:

• dark
• black
• [terminal?]

And if automatic is set, we switch between light and the selected night theme (default dark).

[opusforlife2]

@B0pol See #4148 (comment)

Outdated

[Stypox]

I rebased, squashed some commits, added 731c65c which refactors ThemeHelper and tested thorougly on API 19 (emulated, where there is no device theme system setting) and on API 29 (Fairphone 3). Everything works fine and smoothly. @TobiGr This has also been tested before many times and I think it should be merged. @B0pol could you review my changes?

[Redirion]

Tested on Pixel 4a (API 30). LGTM!