Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Notification might still display progress information below android 10 #4409

Open
3 tasks done
SebiderSushi opened this issue Oct 5, 2020 · 3 comments
Open
3 tasks done
Assignees
Labels
feature request Issue is related to a feature in the app player notification Anything to do with the MediaStyle notification

Comments

@SebiderSushi
Copy link

SebiderSushi commented Oct 5, 2020

Checklist

Describe the feature you want

NewPipe might be able to still communicate the playback process through the new notification introduced with v0.20.0.

It seems that this can be achieved by setting the text next to the application name at the top left of the notification to contain the playback time.

Is your feature request related to a problem? Please describe it

I don't run android 10 or newer but like to see playback time information on the notification in background mode as well.

Additional context

Today, after seeing the notifications of NewPipe and AntennaPod right next to each other i noticed that there is a little text next to the application name at the top of the notification. But while NewPipe's notification only shows how long ago that notification was posted, AntennaPod's notification puts the current runtime of the now playing track in that space.

The notifications look almost the same and as it seems from code, AntennaPod might actually be using MediaStyle notifications as well!

How will you/everyone benefit from this feature?

If the burden of implementing and maintaining this feature isn't too high, every NewPipe user will be able to non-intrusively see at least how much of a video has already been played.

@SebiderSushi SebiderSushi added the feature request Issue is related to a feature in the app label Oct 5, 2020
@avently
Copy link
Contributor

avently commented Oct 5, 2020

Related discussion #4332 (comment)

@Stypox
Copy link
Member

Stypox commented Oct 5, 2020

@SebiderSushi this is the specific line setting the timestamp in the notification. This will have to undergo some investigation in terms of performance and battery drain, as it would involve recreating the notification every second.

@comradekingu
Copy link
Contributor

@Stypox I would argue the seconds ticking is just visual noise. Doing the minutes is plenty for videos where it would even make a difference. The bigger picture is knowing when the video ends, which isn't possible unless clicking the dropdown on AntennaPod(?)

An actual progress bar wouldn't need to be updated as often, given the rather limited resolution. Also it has a marked end, and will visually sit rather still for long videos, or skip ahead quickly for small ones.

As a possible but slight complication, do seconds level resolution for short videos, and minutes level or increasing resolution for longer ones.
Less battery wasted, because only racking up use on shorter stuff.

@Stypox Stypox self-assigned this Oct 5, 2020
@opusforlife2 opusforlife2 added the player notification Anything to do with the MediaStyle notification label Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app player notification Anything to do with the MediaStyle notification
Projects
None yet
Development

No branches or pull requests

5 participants