-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.20.0 #4332
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@XiangRongLin It takes the colour theme from the thumbnail. See the blue bar at the top of your video's thumbnail. |
The option to not show the thumbnail on the lockscreen during background play is gone from the "player" section. Was it removed in purpose or what happened to it? |
This was discussed somewhere very recently. I think the idea was that the option was added because showing the thumbnail was buggy with the earlier notification, but now that we've shifted to MediaStyle notification, it's not needed anymore. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@opusforlife2 How do i now not show the thumbnail on the lockscreen? I have the Android feature active to hide sensitive content, so it is just a blurry image. And i like my own wallpaper.
@opusforlife2 Is there an option to disable it? I really dislike having everything be darkmode and then newpipe sometimes displaying bright yellow/blue/white notifications. |
"Starting at Android O any notification that has a media session attached with setMediaSession(android.media.session.MediaSession.Token) will be colorized. You can opt-out of this behavior by using Notification.Builder#setColorized(boolean)." https://developer.android.com/reference/android/app/Notification.MediaStyle @XiangRongLin Maybe this can be added as an option in Notification settings?
@XiangRongLin I suppose the option would have to be added back, or rewritten, maybe, since the related code has changed. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I have noticed two bugs so far:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@eladkarako for me those settings import without issues, what's the problem? |
I found an issue with the fullscreen button on tablets, I'm not sure if this is an emulator issue, but I don't think so.
Note that the behaviour obtained after pressing the fullscreen button is exactly the same as rotating the device, but on tablets rotating the device does not mean going into fullscreen mode. So the fullscreen button should in my opinion rotate the device and then go into fullscreen directly. Anyway, this is not release blocking, so unless @avently has a quick solution we can fix this later in 0.20.1 by ourselves. |
@N0TSUS It's just been fixed. Wait for the next RC. |
IRC. Link is on repo's Readme. 👍 You can join through the browser, your IRC client, or a Matrix account. |
|
@test2a I made this because no one will need to see this two dots everytime. You only need to see them once to know that there are two pages. So they are useless when you already know about this |
@TobiGr the way they worked before makes them appear in fullscreen. So when the player in fullscreen they are visible at the bottom of the screen. |
Sorry to hop in, maybe considere tiny "tabbed" design ? Like [comments/suggestions] ? Could be done in a thin way and would be really easier to understand at first |
Hello, the notification does not display the the current time in the video and how long the video is. |
@yufin1 could you provide the exact steps to reproduce? Are you on Android 10? |
@Stypox I am on android 9. Well it is just the normal notification if I start a video. So I just start playing a video and get the notification. I have used other RCs too and always got this notification without the timebar. But the timebar should be visible i.e. it wasn't removed? |
@yufin1 That's not a bug. That's just a consequence of switching to MediaStyle notifications. The seekbar only appears on Android 10+ now. |
That's a known issue also in previous versions. If, after importing, you completely close the app and reopen it, everything should be fine. |
I just noticed that notification doesn't contain current time and all time. Why? There is a place for a custom string inside notification. So you can pass |
@avently that would require updating the notification every second, which is not a good idea in my opinion, as it would increase battery consumption and hurt performance. |
Last RC for this release: NewPipe_v0.20.0RC7.zip
|
@Stypox from my point of view the cost is acceptable. I think the cost of cpu time should be measured before making a decision |
One week of adapting the code to release. That's cool. Thank you everyone involved into the process. We did a great job! |
@opusforlife2 i'm a bit late but today I read a blog post about changes in this version. The post is so awesome! So detailed, with pictures and comparisons with previous version. Thank you for it. |
@avently Thanks! Poolitzer and I worked on the blog post, and everyone contributed screenshots and short videos. |
Changelogs
App
New
Improved
Fixed
Development
final
isn'tfinal
Add checkstyle rule to show final local variable violations as warning #4138Extractor
Improved
Fixed
APK for testing
NewPipe_v0.20.0RC7.zip
Corresponding PR: #4333
The text was updated successfully, but these errors were encountered: