[regression] Close player in onPlaybackShutdown() #4130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stypox
added
ASAP
Looks ok, I tested and it works correctly even when stream completes. This indeed smarter solution than mine because |
|
Yup. Fixed. |
TobiGr
approved these changes
Aug 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
See #4129. Since this is such a simple change I think it should be merged asap, as to make testing #3178 simpler
@avently is this ok?
Fixes the following issue(s)
Fixes #4129
Testing apk
@opusforlife2 you were encountering this problem in #3178, could you check if it is fixed in this apk?
app-debug.zip
Agreement