Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled preloading when switching streams #4246

Merged
merged 1 commit into from
Sep 25, 2020

Conversation

avently
Copy link
Contributor

@avently avently commented Sep 7, 2020

What is it?

  • Feature (user facing)

Description of the changes in your PR

When you play one video and then select another the player will stop loading the first stream. Which theoretically saves some megabytes while next video is loading. So the first video will NOT stop playing but will stop loading more parts that will never be viewed because the second video shows up.

Fixes the following issue(s)

closes #4232

Testing apk

disabled-preloading.zip

Agreement

Copy link
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
This PR does not only save data, but also speeds up switching streams 👍

Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, too, and by the test I made it works :-D

@TobiGr TobiGr merged commit e0f02d4 into TeamNewPipe:dev Sep 25, 2020
This was referenced Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
player Issues related to any player (main, popup and background)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[unified player] stop current video from preloading when trying to play another one
3 participants