Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to FAQ in the app #4447

Closed
3 tasks done
opusforlife2 opened this issue Oct 8, 2020 · 13 comments · Fixed by #9164
Closed
3 tasks done

Link to FAQ in the app #4447

opusforlife2 opened this issue Oct 8, 2020 · 13 comments · Fixed by #9164
Assignees
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface

Comments

@opusforlife2
Copy link
Collaborator

Checklist

Describe the feature you want

I want the app to show a link to the FAQ in the Drawer, or at least in the About activity.

Is your feature request related to a problem? Please describe it

We frequently come across users who just need one line answers that are explained in the FAQ.

How will you/everyone benefit from this feature?

Increased user awareness; better impression of Newpipe; less work for the team in fielding basic questions.

@opusforlife2 opusforlife2 added the feature request Issue is related to a feature in the app label Oct 8, 2020
@Stypox
Copy link
Member

Stypox commented Oct 8, 2020

You can try to add this yourself, it is pretty straightforward ;-)
Just copy-paste a title-description-button block from the about activity (e.g. Contribute-Whether you...-VIEW ON GITHUB), change the ids of the views and change the strings they show, and in the AboutActivity copy-paste the code that handles the other open buttons and replace the references to the new button's id.

@opusforlife2
Copy link
Collaborator Author

Wanna bet I'll be asked for a test apk? I'm very sure I'll have to open up Android Studio anyway. 🤭

@opusforlife2
Copy link
Collaborator Author

@Stypox The steps you've told me seem to be for adding it to the About activity. I think it would be better for it to go in the Drawer. More visibility. Users rarely open About screens in apps.

@opusforlife2 opusforlife2 added the GUI Issue is related to the graphical user interface label Aug 16, 2022
@Yuuu2990
Copy link
Contributor

Hey, could I work on this issue?

@Stypox
Copy link
Member

Stypox commented Oct 18, 2022

Sure :-)

@Yuuu2990
Copy link
Contributor

Yuuu2990 commented Oct 19, 2022

@Stypox Hi, I have a initial design for this issue as shwon in the below pictures. For the page, in order to make 'FAQ' more bold, I add background color for it. And I test my solution on two different size of the sreen and then it all works.
By the way, Could you assign this issue for me? :-)
Screenshot_1666173426
Screenshot_1666172982

@Stypox
Copy link
Member

Stypox commented Oct 19, 2022

@Yuuu2990 Sorry, but that button does not look good. It does not conform to design standards (Material design) because of the strange colors, the size and the position.

This is what I propose instead:

  • change the name of the entry in the drawer menu from "About" to "About & FAQ", so that users know where to look for answers
  • add a section titled "Frequently asked questions", with a proper description (choose a good description with @opusforlife2) and a button that says "view on website"

In order to do the last point follow my previous instructions: #4447 (comment)

@Yuuu2990
Copy link
Contributor

Yuuu2990 commented Oct 20, 2022

@Stypox Hi, according to your instruction, I have modified the pages as shown in the screenshots. What do you think? :-)
v2-1
v2-2

@Stypox
Copy link
Member

Stypox commented Oct 20, 2022

@Yuuu2990 thank you! That looks good to me. Maybe just put the "Frequently asked questions" section at the top. Then feel free to open a PR ;-)

@Yuuu2990
Copy link
Contributor

Yuuu2990 commented Oct 20, 2022

@Stypox According to your advice, I readjust the layout as shown below. Does it look good for you? If you think it's ok, I will open my PR. :-)
V3-1

@Yuuu2990
Copy link
Contributor

@Stypox Btw, Could you assign this issue to me? Since it is about my assignment of school for me.

@Stypox
Copy link
Member

Stypox commented Oct 20, 2022

Yes, I think it's ok

Yuuu2990 added a commit to Yuuu2990/NewPipe that referenced this issue Oct 21, 2022
Stypox added a commit that referenced this issue Oct 26, 2022
* Link to FAQ in the app #4447

* remove redundant comments produced by me.

* Update app/src/main/res/values/strings.xml

Update FAQ description

Co-authored-by: opusforlife2 <53176348+opusforlife2@users.noreply.github.com>

* Format the CodeStyle and readjust the layout.

* Update app/src/main/res/layout/fragment_about.xml

Remove redundant id.

Co-authored-by: Stypox <stypox@pm.me>

* Update app/src/main/res/layout/fragment_about.xml

Remove redundant id.

Co-authored-by: Stypox <stypox@pm.me>

* Update app/src/main/res/values/strings.xml

Keep the uppercase for consistency.

Co-authored-by: Stypox <stypox@pm.me>

* Update app/src/main/res/values/strings.xml

Modify the description of FAQ.

Co-authored-by: Stypox <stypox@pm.me>

Co-authored-by: opusforlife2 <53176348+opusforlife2@users.noreply.github.com>
Co-authored-by: Stypox <stypox@pm.me>
@opusforlife2
Copy link
Collaborator Author

Thank you for addressing my feature request, @Yuuu2990! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants