-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link to FAQ in the app #4447
Comments
You can try to add this yourself, it is pretty straightforward ;-) |
Wanna bet I'll be asked for a test apk? I'm very sure I'll have to open up Android Studio anyway. 🤭 |
@Stypox The steps you've told me seem to be for adding it to the About activity. I think it would be better for it to go in the Drawer. More visibility. Users rarely open About screens in apps. |
Hey, could I work on this issue? |
Sure :-) |
@Stypox Hi, I have a initial design for this issue as shwon in the below pictures. For the page, in order to make 'FAQ' more bold, I add background color for it. And I test my solution on two different size of the sreen and then it all works. |
@Yuuu2990 Sorry, but that button does not look good. It does not conform to design standards (Material design) because of the strange colors, the size and the position. This is what I propose instead:
In order to do the last point follow my previous instructions: #4447 (comment) |
@Stypox Hi, according to your instruction, I have modified the pages as shown in the screenshots. What do you think? :-) |
@Yuuu2990 thank you! That looks good to me. Maybe just put the "Frequently asked questions" section at the top. Then feel free to open a PR ;-) |
@Stypox According to your advice, I readjust the layout as shown below. Does it look good for you? If you think it's ok, I will open my PR. :-) |
@Stypox Btw, Could you assign this issue to me? Since it is about my assignment of school for me. |
Yes, I think it's ok |
* Link to FAQ in the app #4447 * remove redundant comments produced by me. * Update app/src/main/res/values/strings.xml Update FAQ description Co-authored-by: opusforlife2 <53176348+opusforlife2@users.noreply.github.com> * Format the CodeStyle and readjust the layout. * Update app/src/main/res/layout/fragment_about.xml Remove redundant id. Co-authored-by: Stypox <stypox@pm.me> * Update app/src/main/res/layout/fragment_about.xml Remove redundant id. Co-authored-by: Stypox <stypox@pm.me> * Update app/src/main/res/values/strings.xml Keep the uppercase for consistency. Co-authored-by: Stypox <stypox@pm.me> * Update app/src/main/res/values/strings.xml Modify the description of FAQ. Co-authored-by: Stypox <stypox@pm.me> Co-authored-by: opusforlife2 <53176348+opusforlife2@users.noreply.github.com> Co-authored-by: Stypox <stypox@pm.me>
Thank you for addressing my feature request, @Yuuu2990! 🥳 |
Checklist
Describe the feature you want
I want the app to show a link to the FAQ in the Drawer, or at least in the About activity.
Is your feature request related to a problem? Please describe it
We frequently come across users who just need one line answers that are explained in the FAQ.
How will you/everyone benefit from this feature?
Increased user awareness; better impression of Newpipe; less work for the team in fielding basic questions.
The text was updated successfully, but these errors were encountered: