Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll comments/related streams under video #4484

Open
3 tasks done
opusforlife2 opened this issue Oct 11, 2020 · 18 comments
Open
3 tasks done

Scroll comments/related streams under video #4484

opusforlife2 opened this issue Oct 11, 2020 · 18 comments
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface player Issues related to any player (main, popup and background)

Comments

@opusforlife2
Copy link
Collaborator

opusforlife2 commented Oct 11, 2020

Checklist

Describe the feature you want

When scrolling comments/related streams, the video should stay on screen and comments/streams should disappear under it.

Is your feature request related to a problem? Please describe it

People who are used to Youtube's behaviour find it very strange that the video scrolls as well.

Additional context

This is feedback I've gotten from a user.

@opusforlife2 opusforlife2 added feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface player Issues related to any player (main, popup and background) labels Oct 11, 2020
@Stypox
Copy link
Member

Stypox commented Oct 11, 2020

I think this was already discussed in #2907 and @avently was against it. I am personally in favour of this, but it would be really difficult to implement in a good way for every possible configuration of: vetical/horizontal video, landscape/portrait, fullscreen/not fullscreen, ...

@opusforlife2
Copy link
Collaborator Author

It only has to happen for the player embedded in video details in portrait orientation, not full screen. In landscape, videos always play in full screen.

@avently
Copy link
Contributor

avently commented Oct 11, 2020

@Stypox

really difficult to implement in a good way for every possible configuration of: vetical/horizontal video, landscape/portrait, fullscreen/not fullscreen,

yeah, I didn't think of it. Actually implementing like this would prevent from scrolling in fullscreen which is a useful thing now

@Maxwell12347842
Copy link

i would love if this would be implemented again. i hated it after updating how it is now.. this & other things (design related) that got changed in the last update got me to downgrade again since i hate a lot of the new layout design decisions. it was better and more userfriendly before the last update IMHO.

@skyGtm
Copy link

skyGtm commented Jan 19, 2021

@Stypox @opusforlife2
This will help #5450 (comment)

@Dangelman
Copy link

I like scrolling comments while viewing a video in portrait. Would def love to see this feature in NewPipe.

@MD77MD
Copy link

MD77MD commented Jan 12, 2022

@opusforlife2
I think this should be added to Major planned/missing features #6448

@MD77MD
Copy link

MD77MD commented Jan 12, 2022

I also strongly suggest for this to be optional in settings ... to accommodate all different devices and use cases.

@opusforlife2
Copy link
Collaborator Author

@MD77MD It's not major because the functionality is present using the popup player workaround. This would be a convenience, certainly, but it's not 'missing'.

@MD77MD
Copy link

MD77MD commented Jan 15, 2022

you have a point but as you said its way more convenient

@jivemelon
Copy link

are there any plans for this at all, or any time soon? I think using the popup player to achieve this functionality is a pretty hacky solution.

@opusforlife2
Copy link
Collaborator Author

Nope. No one has volunteered to work on this, so far.

@joshuabengal

This comment was marked as duplicate.

@adamency
Copy link

adamency commented Sep 14, 2023

@Stypox
yeah, I didn't think of it. Actually implementing like this would prevent from scrolling in fullscreen which is a useful thing now

Can you explain how you scroll while in full screen ? Cause I don't see any way to do this. This doesn't even seem to mean anything, as if you're reading comments you're by definition not in fullscreen.

And even if this is a thing, we simply have to activate this only in portrait mode, and keep the current behavior in landscape. Doesn't seem to be an obstacle.

@MD77MD
Copy link

MD77MD commented Oct 10, 2023

I think this should be included in the rewrite

@opusforlife2
Copy link
Collaborator Author

The rewrite is being done to make future development easier. So technically, all features that are left for after the rewrite are 'included' in it.

@SyCoREAPER

This comment was marked as spam.

@ReEnMikki

This comment was marked as duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface player Issues related to any player (main, popup and background)
Projects
None yet
Development

No branches or pull requests