Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always fit video according to aspect ratio on main and popup player #6071

Open
3 tasks done
SameenAhnaf opened this issue Apr 13, 2021 · 0 comments
Open
3 tasks done
Labels
feature request Issue is related to a feature in the app player Issues related to any player (main, popup and background)

Comments

@SameenAhnaf
Copy link
Collaborator

SameenAhnaf commented Apr 13, 2021

Checklist

Describe the feature you want

Main player should completely ditch the 'Fit/Fill/Zoom' option.

Video should fit on left side in case of setting the app on landscape (Same as we see now in case of TV). This will also let us have transcript feature on any view. In case of tall portrait videos on short screen (9:16 videos on 3:4 screen), videos should be zoomed.

Is your feature request related to a problem? Please describe it

Android phones have different aspect ratio, so do the videos. The main purpose of main player is to have a hassle-free view. Especially, 'Fit' option is completely useless for portrait videos.

Additional context

Related: #6044, #4484

How will you/everyone benefit from this feature?

Users will be able to enjoy the widest view regardless of setting the app on portrait or landscape. Also, the hassle of changing view frequently especially in case of portrait videos will be removed. If you noticed carefully, 'Fit/Fill/Zoom' doesn't actually work the same for main player and full screen player. That confusion will be also removed.

@SameenAhnaf SameenAhnaf added the feature request Issue is related to a feature in the app label Apr 13, 2021
@SameenAhnaf SameenAhnaf changed the title Fit video according to aspect ratio on main player Always video according to aspect ratio on main player Apr 15, 2021
@SameenAhnaf SameenAhnaf changed the title Always video according to aspect ratio on main player Always fit video according to aspect ratio on main player Apr 16, 2021
@SameenAhnaf SameenAhnaf changed the title Always fit video according to aspect ratio on main player Always fit video according to aspect ratio on main and popup player Apr 19, 2021
@SameenAhnaf SameenAhnaf reopened this May 18, 2021
@SameenAhnaf SameenAhnaf added the player Issues related to any player (main, popup and background) label Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app player Issues related to any player (main, popup and background)
Projects
None yet
Development

No branches or pull requests

1 participant