-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Player UI #1317
Comments
I'd prefer something similar to VLC's layout, where the play/pause, previous, next selections are dropped to the bottom, creating something similar to our background player queue. Where these three buttons are surrounded by 3 other most used functionalities and an overflow button, which less used buttons are shown on a translucent dialog. This way, we drop all button access to the bottom of the layout, making control easier on the hand and fingers. Also, we should merge all track (audio/video/subtitle) track selection to a single dialog, similar to the ExoPlayer demo app. After the player is refactored, swapping between the popup and main players should be fast enough that we don't really need to have many UI elements on the popup and can just change/inherit the settings from the main player. |
Implemented as own player for devices with lower display resolution. Would be the solution to this. And through the swiping for this player away. |
2 more suggestions on the UI front:
|
This comment has been minimized.
This comment has been minimized.
Describe the feature you wantRight now we have to select arrow down button in order to see second line of buttons like subtitles, aspect ratio, open in browser, etc. This is fine until someone will want to show more buttons inside this line. All the buttons from second line should be replaced with AlertDialog or BottomSheet or Popup menu with enabled icons. I'm not sure which one is the best, needs testing to be sure. Popup menu allows to show submenu for subtitles and aspect ratio which is useful. By making this change we can leave arrow down button but make it working like a scroller to the description. This will allow to tap on it and to see a description even in fullscreen. Once someone make a swipe-to-go-to-description even this button can be removed. So the proposed look of the buttons in non-fullscreen: In fullscreen: If the Is your feature request related to a problem? Please describe itThe problem is there are to many buttons. Some users want to add even more buttons. I don't think this UI element like second line with buttons is a great element in the case of many buttons. How will you/everyone benefit from this feature?We can close many issues after this idea is implemented. Also the player will be much faster in case of view relayout because it will lose some buttons. |
Not sure how other devs will find this old issue, but anyway. What you guys think about the idea to replace second line of buttons with dialog or something similar? |
A dark transparent version of what is in the OP would be my preference. |
@avently I agree with you and @opusforlife2, the current layout looks good with a small number of buttons, but already does not feel completely right. I might work on this in the future, though not for 0.20.1, as it would take some time and thoughts |
@Stypox : I wanted to open a discussion, but it has not yet been decided whether to enable them or not. I would recommend a ui similar to that of the youtube player.
|
@Stypox : How about changing the video preview ui. I put a white border in the preview image and changed the order to the first image and then under the time. |
The time was put above after a decision by the team, and won't be reverted |
@Stypox :About that #1317 (comment) |
Yeah I want to add an idea to the UI design on the chapter element |
Full Screen Player UI:
Audio options will be included in resolutions' list. So, no background button is required. For popup and main player, same UI would be applied but For full screen portrait player, |
The real estate on devices with smaller screens is quite limited, so a lot of these buttons will have to be dynamically pushed into menus. |
The closer we can get to VLC player functionality but without the clutter, the better. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Please be aware that further discussions should better be made over at the NewPlayer repo: https://github.com/teamNewPipe/newplayer |
@theScrabi : Will this repo be closed? |
no, NewPlayer will not replace NewPipe. NewPlayer will be the updated media player component in NewPipe but NewPlayer can also be used in any app |
At the moment our player UI is quite untidy and not easy to use on small devices. In addition, the symbol for additional actions is very small and therefore difficult to reach.
My suggestion to make more options accessible is a second overlay which can be opened via the settings icon in the right corner. Tapping on an icon on that screen should open another instance with more options if necessary. Tapping on free space should close the menu.
I added a placeholder for Pipecast or any other feature (equalizer, ...) so we won't have to spend time on restructuring it again in the near future.
I thought about the problem with the tiny popup which has even less space to work with. Maybe we should just open NewPipe to adjust the popup settings and close it afterwards or auto-resize it until the menu gets closed.
@theScrabi @karyogamy @mauriciocolli @wb9688 Is there anything else we need to add to the player?
The text was updated successfully, but these errors were encountered: