Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make no available subtitles (or captions) more obvious #6339

Open
3 tasks done
jmbreuer opened this issue May 21, 2021 · 2 comments
Open
3 tasks done

Make no available subtitles (or captions) more obvious #6339

jmbreuer opened this issue May 21, 2021 · 2 comments
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface player Issues related to any player (main, popup and background)

Comments

@jmbreuer
Copy link

Checklist

Describe the feature you want

The closed captions / subtitles control should still be visible and disabled or slow only a "no subtitles [available]" entry, when there are no subtitles available for a specific video from a provider that supports subtitles in principle (ie YouTube).

Is your feature request related to a problem? Please describe it

I started to watch a video in a foreign language and searched all of NewPipe's UI high and low for how to turn on subtitles before I realized this particular video doesn't have any and this causes NewPipe to completely remove the subtitle controls.

Additional context

This video: https://youtu.be/DcWhtTXaWE4

How will you/everyone benefit from this feature?

New users will be less likely to think that NewPipe may be missing subtitle functionality in general, which is what happened to me at first.

Less confusion.

@jmbreuer jmbreuer added the feature request Issue is related to a feature in the app label May 21, 2021
@triallax triallax added GUI Issue is related to the graphical user interface player Issues related to any player (main, popup and background) labels May 26, 2021
@SameenAhnaf
Copy link
Collaborator

@mhmdanas Isn't this a duplicate of #5378?

@triallax
Copy link
Contributor

triallax commented Sep 3, 2021

No, it's not. This issue requests that the caption control in the player remain even when there are no captions and that it should show that no captions are available, while that issue requests for a CC/subtitle thingy which can be seen before even opening the video. Somewhat similar, but not quite the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface player Issues related to any player (main, popup and background)
Projects
None yet
Development

No branches or pull requests

3 participants