-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start playing from here/ Enqueue from here #4805
Comments
..yeah this feature was there upto v0.16.2 but was removed sadly in 0.17.0. It was really helpful. I miss it just like yesterday. Probably needs a couple of lines of code. |
This comment has been minimized.
This comment has been minimized.
really, i guess i was late to the party 😁, anyway like you said this makes things alot easier. |
Pinging:
Why was @BartFarley's comment marked as "disruptive comment" when it is nothing but the truth? Please stop silencing / ignoring opinions that do not align with what you think. You did that to me as well when I was explaining why that feature was essential to me and was told by more than one of the devs that this function cannot be essential to me because they don't use it at all. (That was a little WTF-Moment for me to be honest) Anyway, let's be constructive: I see that my suggestion to put the button toggling the auto-play function in a more prominent position has been implemented in the meantime. If someone could finally fix the list of upcoming videos to only contain the playlist items in an ordered fashion if a video was started from a playlist that would solve all the problems and make the play from here obsolete. Cheers |
If the tone of a comment is aggressive or even passive-aggressive, it will be minimized. You are free to ping all the people for whom this issue is relevant, sure, but directly or indirectly attacking a developer who volunteers their free time will not be tolerated. Since your comment quotes the entire previous comment, I'm editing it a little bit. |
@opusforlife2 that's understandable, of course, but I'm under the constant impression that criticism gets confused with aggression here far too easily. |
I'm not aware of this happening since I've started maintaining issues. Can you give other examples? I would like to analyse them. |
@opusforlife2 Sorry if I was a bit unclear here maybe but I was talking about this specific thread because imho there‘s no aggression in @BartFarley‘s comment but facts |
When you said "constant impression", I thought you had more than one instance in mind... |
Yeah, that‘s what I meant with being unclear. Sorry about that. |
Firstly, thank you @astamminger. You get it. Every sentence in my last comment was the truth. No agression. No attack. Just the facts. Version 20+ is a disaster. Please put "play from here" back in Don't become the latest FireFox (Disaster) Gnome 3 flashbacks! Implementing an audio volume normalizer in NewPipe would be useful. |
@BartFarley @astamminger Are you and the users you linked aware of #2518? |
I can only speak for myself. Yes, I'm aware of #2518. |
We developers can't unfortunately implement everyone's needs without breaking sombody else's. That's why I decided to make menus consistent and remove an action that only saved really little time (and now thanks to unified ui is not needed anymore). I get that some of you may have needed it, but all of the other people would just get confused by a long list of possible action and say "I can't understand NewPipe and it is really inconsistent, better to stick with YouTube". Therefore for now this will stay as it is, until a proper solution is implemented. I proposed #2583, trying to suit everyone's needs, but then I realised that would also be bad for people not much into technology. Another solution is needed. |
@Stypox can you please elaborate on this? What do you mean by "saved really little time"? Compared to what? I certainly might be missing something here but back then "Start playing from here" was my only option to start from a specific (video!) playlist track and auto-queue the upcoming videos from the playlist and only from the playlist. That was because enabling the auto-play option from the menu would play the selected video and continue to enqueue videos from the random list of related videos. However! I suggested to use an auto-queue option for playlists (#2510 (comment) :D) and I am happy to see that this has been finally implemented and works. Thank you guys 👍 |
what are you breaking here, nothing
Unified UI has nothing to do with this, we need this because simply thier is no alternative.
I don't understand how would anyone get confused by this. many top video apps have this option including VLC. believe me, people are more familiar to this option than you think.
this is exactly whats getting people upset. everything depends on what you like... eg. like they notification color (which I consider an nich), only one person asked for it and it was merged immediately into the next release while others were begging you to keep the remember pop up position (which i don't use) but you still removed it. on the other hand there are so many more important request that effect NewPipe usability are left out or denied simply because you don't need them or dont interest you. this is not right. its a discussion bro, sometime we need to give in even if we're not completely into the idea. especially if they're small things like this request.
at this rate, its very unlikely. anyway just to be clear, Im grateful for everything you are doing here @Stypox i just which if you would open a little more for us and understand we are on your side and support you. I would also like to extend my gratitude to @opusforlife2 @B0pol @TobiGr and everyone helped in the 0.20.3 release |
I did not read this issue entirely but I want to answer about notification: It was a must to change to Android MediaStyle notifications, because ours it did not work on Android 11. |
im not against it, im just saying we should leave some room for people's feedback in our decisions. especially in the small stuff that's all. |
The point is the resulting overfilled dialog. It just doesn't look good to have repeated actions which differ in single words and containing the same word - in English it's "Queue", in German for example it's "Wiedergabe" which is pretty long to be honest o.0
Nah, that's totally fine. The devs aren't paid and work in their freetime, so they pick the issues/enhancement they like if it isn't a required one (everything except those which fix the service). But there're so many out there, sooner or later these will be worked on - or not xD |
Now regarding this feature, apparently it was done before but was removed. and gassing from the hot timbers showing in the early comments, others have been requesting to readd it but where rejected in a cold way. what i propose is to exercise the same flexibility we used in the forward/rewind behavior feature #4264 (just a great experience all over). we could readd this in a beta mode, and see people's reaction toward it. if people like it or needs a bit of tweaking and it's not too confusing then great. but if people's feedback is negative or a better solution is found then we can just delete it. at least this way we can be sure we are making the right decision. what do you think guys? i hope I'm not being too pushy😁. |
I'm throwing this workaround idea into the room due to maaaaany complaints (well, it's not perfect, but just for the idea): https://streamable.com/e/dpyxep This would only appear in the playlist fragments (local, remote) and history (is it really needed there in the first place due to the changing order after every video?). The actions in the initial dialog refer to single streams, so for example "Start playing in background" starts a list of 1 even in lists. |
Do you mean that this action will play just 1 song from a playlist even if there are other songs down the list? Currently this action starts playing a playlist from the selected song and plays it up to the last song of the playlist. And this is totally desired behavior for me. Honestly, I can't imagine why someone may want to play just one song of the playlist. This is the main purpose of playlists - play songs of the list. :) If this behavior (play just one item in the list) is really desired for someone, then maybe it's worth to add some switcher on the screen, that will control this behavior (ON - all actions that starts playing any item will continue to play the list, OFF - all these actions will stop playing after song is over). |
Yes.
Yesterday for example: #5070 But there may be some other cases. NewPipe doesn't provide a "Watch later" functionality, so you have to create a playlist for this purpose. Then you don't want enqueue all streams at once, maybe just picking some of them :) |
@vkay94 Ok, you convinced me that this behavior is desired by some people. :) But other behavior is desired too (I mean "Start playing from here and play until playlist ends"). How could I do this if what you described will be implemented? Are new "enqueue" actions from submenu in the video do this? I'm very confused because "enqueue" means that I want to enqueue some items after some other items which are already in the queue. But this is not the same as "Start playing from here (in background)" action (that clears the queue before enqueuing part of current playlist) that is most useful action for me. |
@xak2000 This is inside the sub-menu after clicking on "Queue options" (there is the small arrow as indicator). Also the "Enqueue from here" requested from the OP.
I've picked all string values fastly, so there is definitely place for improvement ;) . I just wanted to show the idea to implement the request of this issue in the first place (provide the feature while keeping the menu as light as possible). |
So, "Enqueue from here in background" in your video actually means "Start playing from here in background"? Is this correct? And, if yes, then where is real "enqueue in background" action? :) I'm speculating here ofc. Personally, I don't need such option. But I'm sure there are users who need it, so they can quickly enqueue some videos from multiple playlists/etc into queue (without emptying this queue or stopping playing currently playing track) and then play this queue. Another drawback of this solution is that some actions are more accessible than others. E.g. currently I need to do just 2 taps to start playing playlist starting from selected track in the background. But if what you shown in the video will be implemented, I'll need to do 3 taps. While some other user who prefers playing just one track will need only 2. Of course, you could argue that submenu will contain actions that are used most infrequently. But how can we know what actions are really used frequently and what are not? Is there are Google Analytics or something present in the app, that tracks user taps? |
Correct.
Depends. If you mean enqueueing a single stream then it's "Start playing on background" if there's nothing playing in the moment otherwise "Enqueue" which enqueues the stream into the current player (current behavior) without interrupting playback.
Yeah, that might be true. From another aspect you have to weight: either all functionalities in one place as long (scrollable) list or remove/drop some of them or re-structure. That's the problem by differentiate between background and popup in the dialog - you have every play action twice (except for the "Enqueue" action).
Probably? ^^ Just kidding ;) I'm full aware that it's impossible to make everyone happy. As said it's an idea of what's possible :) Thanks for the feedback by the way :) |
But new "Enqueue.." actions will actually start playing from scratch, as you just confirmed. Not really enqueue. So it will be required to add several other actions into submenu, like:
etc. Edit. I noticed these "Load..." actions in the submenu in your video. Maybe it's "Start playing from here.." actions? If yes, then forget what I wrote up here. All 4 mentioned actions are present, just named differently. :)
Maybe if user will be allowed to enable/disable each menu item and reorder them from configuration screen, it's possible. ;) Or at least allow to reorder menu items. In this case all "excessive" items (like 6th item and more) can be automatically hidden under "arrow submenu" as in your video. This way each user can put 5 most useful for him actions at the top of the list and will be able to access them with 2 taps, while 6th and more actions will be still accessible with 3 taps. Just an idea! To be honest, I'm not very adherent to this idea, because popup menu with many items is not a good UX anyway (if you ever used IntelliJ IDEA, you could know how hard is to find required item from context menu sometimes, even if you used it before million times). So it's better to come up with something better idea. But the idea of removing some useful actions is much worse in my opinion. :) |
Double on this. Maybe something else? A grid of actions with icons and labels? Or a circle menu? Or maybe an accordion list. Might be grouped/hierarchical. May even make "tap on video in a plylist" default to "Play from here" instead of "Open just one video". Or any other default video action, but it should consider the whole playlist, not the individual video in it, as it does now. |
I think that can't be handled well and would be more problematic than benefiting because you've got many such dialogs for normal streams, in history, in local and remote playlist. Also it's not common to edit such item based menus.
From my perspective I had such in mind to try (grid) but the differentiating of background and popup would make it a total mess - you'll need much text to explain the function, 1-2 words and an icon aren't enough. |
Another idea. Make menus structured this way:
Where "etc" is other modes to playing a stream. I just am not familiar with all modes of playing that NewPipe supports. I use only "in background" mode always because I use youtube playlists on phone only for music listening. This way 1st level menu will always have just 4 menu items. Or it could be done this way instead:
This way there will be only 2 menu items in main menu. But text of submenu items will be longer, unfortunately. Otherwise they will be not descriptive enough. Which way is better depends on how many other menu items (this "etc" items in my examples) need to be placed in submenu. By the way, do we really need all these options for enqueue? I mean "In backgorund", "In popup" etc. Can't the mode of enqueuing be inherited from the type of currently playing queue? I mean, we can have just 2 menu items for enqueuing:
And videos will be enqueued to the current queue, whatever it is. E.g., if current queue is playing in the background, then new tracks will be enqueued to the end of this queue also in the background. If current queue is playing in a popup, then new tracks will be enqueued to the end of this queue also in a popup. Maybe I don't understand how the queue work.. In my mind the queue is single and you just add items to it and then can play this queue in the foreground, in the background or in a popup or whatever mode NewPipe supports and switch between these modes at any moment (without losing the queue). Or it doesn't work like this? Sorry for maybe stupid question, but I really use NewPipe only to play music playlists in the background, so my pattern of use is closer to native YouTube application. I'm not familiar with the queue in NewPipe and never use it explicitly. Only implicitly through playing playlists, I think. In my mindset, I'm playing a playlist directly: track after track. |
#5741 includes all types of enqeue options. |
.
Checklist
Describe the feature you want
Although after merging #4425 (Replace specific enqueue options with one done by @vkay94 ) made enqueueing videos alot easier, one key change that was needed was overlooked, that is the ability to start play/enqueue videos from the middle of playlist.
Edit (Dec 10):
Is your feature request related to a problem? Please describe it
The problem is if you want to start playing/enqueue videos from the middle of a playlist, you can't. you can use a work around which is start playing in background/pup-up mode then change to full screen mode however that not right. or you can enqueue videos, one by one, which is not practical especially in big playlists to say the least.
Additional context
I wish if we could add to context menu:
How will you/everyone benefit from this feature?
This would not only solve playing playlist from the middle but also able is to enqueue playlist while a video is playing
The text was updated successfully, but these errors were encountered: