Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speedmenu layout in landscape mode #4913

Closed
3 tasks done
defini-tiv opened this issue Nov 18, 2020 · 5 comments · Fixed by #7363
Closed
3 tasks done

Speedmenu layout in landscape mode #4913

defini-tiv opened this issue Nov 18, 2020 · 5 comments · Fixed by #7363
Assignees
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface

Comments

@defini-tiv
Copy link

defini-tiv commented Nov 18, 2020

Checklist

Describe the feature you want

I think the speed control should have another layout in landscape mode, so most users don't have to scroll.
There is an image how it could look

Is your feature request related to a problem? Please describe it

At the moment you have to scroll through the menu and see not all options at the same time.
I have to admit that my phone screen may be a bit thin and long but i think it is the same issue on many other devices that the menu is too big in vertical and has enough space left on the sites.

Additional context

At the time:
old_speed-menu
My suggestion:
new_speed-menu

How will you/everyone benefit from this feature?

Its just a detail, but i think it would improve UX because you see everything after opening it up and don't have to scroll anymore - it would just feel cleaner.

@defini-tiv defini-tiv added the feature request Issue is related to a feature in the app label Nov 18, 2020
@opusforlife2 opusforlife2 added the GUI Issue is related to the graphical user interface label Nov 18, 2020
@Stypox Stypox added the good first issue Easy/simple issues perfect for newcomers to get involved in the project label Nov 18, 2020
@MD77MD
Copy link

MD77MD commented Nov 22, 2020

good catch😎

@defini-tiv defini-tiv changed the title Speedmenu layout in prtrait mode Speedmenu layout in landscape mode Dec 16, 2020
@Hugov8
Copy link

Hugov8 commented Oct 26, 2021

Hello, we are a group of students, can we work on this issue ?

@defini-tiv
Copy link
Author

If you ask me: of course!
I think many people would benefit and i would be very thankful by my self.

@litetex
Copy link
Member

litetex commented Nov 4, 2021

After reviewing #7351 I want to note a few things that should be considered:

  • Having 2 layouts causes 2x maintenance effort.
    There have been similar problems in the past when something was added to player: Someone forgot to add a button on the large-player and the whole app crashed on TV and tablets.
  • The dialog is adjusted to the device. Some devices will always have this problem particularly small/old devices.
  • With different languages the required text-area sometime gets larger. Which then also causes problems.

So I would keep it stupid simple:
Keep one layout and remove some useless spaces/margins from that layout.

I did that with a few simple changes and I think the results are actually pretty good:
grafik

Update: Removed the (obvious) header (see #7363 (comment))

@litetex litetex removed the good first issue Easy/simple issues perfect for newcomers to get involved in the project label Nov 4, 2021
@litetex
Copy link
Member

litetex commented Nov 4, 2021

Created a PR for my implementation: #7363

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface
Projects
None yet
6 participants