Simple playback-speed-controls improvements

[litetex]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

• Improved some paddings/margins in dialog_playback_parameter.xml
• Removed the header, see Simple playback-speed-controls improvements #7363 (comment)

"Why another PR for this issue?" → #4913 (comment)

Probably supersedes

• Playback landscape improvement #7351
• Make "Playback speed controls" dialog contents more compact #6150

In case we also want to change the order of the checkboxes...

No new layout is required, simply implement this:

    private void setDialogMode(final View view, final boolean landscapeMode) {
        final LinearLayout layoutAdditionalOptions =
                view.findViewById(R.id.additionalOptions);
        final List<CheckBox> additionalOptionsCheckboxes =
                Arrays.asList(
                        view.findViewById(R.id.unhookCheckbox),
                        view.findViewById(R.id.skipSilenceCheckbox)
                );

        layoutAdditionalOptions.setOrientation(
                landscapeMode
                        ? LinearLayout.HORIZONTAL
                        : LinearLayout.VERTICAL
        );

        for (final CheckBox checkBox : additionalOptionsCheckboxes) {
            final LinearLayout.LayoutParams layoutParams =
                    (LinearLayout.LayoutParams) checkBox.getLayoutParams();
            layoutParams.width =
                    landscapeMode
                            ? 0
                            : LinearLayout.LayoutParams.MATCH_PARENT;
            layoutParams.weight = landscapeMode ? 1 : 0;

            checkBox.setLayoutParams(layoutParams);
        }
    }

Before/After Screenshots/Screen Record

• Before:

• After:

Fixes the following issue(s)

• Fixes Speedmenu layout in landscape mode #4913

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

• I read the contribution guidelines.

[MD77MD]

if both check boxes where put at the same raw... to eliminate scrolling... which is the point of all the PRs

[litetex]

if both check boxes where put at the same row... to eliminate scrolling... which is the point of all the PRs

This does not work on some languages like e.g. German (where the "Unhook"-text is relatively large) or on small devices.
The scrollbars will always be there in some kind of situation.

[Fs00]

A personal opinion on this: I would remove the "Playback Speed Controls" title rather than constrict it at the top, which doesn't look too good.
I think that the purpose of the dialog would be clear enough even without the title.

[litetex]

A personal opinion on this: I would remove the "Playback Speed Controls" title rather than constrict it at the top, which doesn't look too good. I think that the purpose of the dialog would be clear enough even without the title.

I like this idea.
It is really kind of obvious that these are the playback speed controls so I guess we can remove the title without harm :)

Update: Applied and committed (see issue-description for updated demo image)

[opusforlife2]

So has the need for scrolling been removed completely after removing the title?

[litetex]

So has the need for scrolling been removed completely after removing the title?

Yes. On "normal" devices like a Pixel 3a (5 inch display).

However small ones like a Nexus S (from 2011; Android 2.3.x with 4 inch display) will always have this kind of problem. It's "unfixable" there.

[MD77MD]

i think it's a good enough now

[opusforlife2]

Alright. Seems like this is the best we can achieve here. 👍

[Redirion]

lgtm

[goyalyashpal]

It is really kind of obvious that these are the playback speed controls so I guess we can remove the title without harm :)

bad bad, i dont agree :(

especially bad when getting the elder people onboard with "smartphones" and stuff

but ohkayyy....