Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.21.14 #7473

Closed
litetex opened this issue Nov 30, 2021 · 14 comments
Closed

Release 0.21.14 #7473

litetex opened this issue Nov 30, 2021 · 14 comments
Assignees

Comments

@litetex
Copy link
Member

litetex commented Nov 30, 2021

For newcomers:
This is a preview for the next release.
Feel free to test it, so we can fix any regressions before releasing.

APK

app-RC2.zip
Built from corresponding PR: #7475

Changelog of NewPipe (for more details see the above PR)

New

6 - Add a "add to playlist" option in the share menu #7194
14 - Add "Check for updates" button in update settings #7296
15 - Add support for y2u.be links #7304
17 - Support PeerTube short links #7353
23 - Show action to mark stream as watched all long press menus #7160

Improved

1 - Fix clicking timestamp shows Toast "Playing in popup mode" #7202
5 - Check if background player already active before displaying player toast #7224
7 - Added the 'Show Channel Details' menu item to the Queue long press menu #7222
13 - Use custom TextViews and EditTexts in all XML resources #7061 #7348
19 - [Feed] Save "Show watched items" toggle's status #7370
22 - Simple playback-speed-controls improvements #7363
24 - Rework feed new items handling #7050

Fixed

16 - Fixed shuffle button opacity UI bug #6844
25 - Prevent automatic replay after returning from background #7381
30 - [YouTube] Likes and dislikes extraction #7467 / TeamNewPipe/NewPipeExtractor#753

Localization

31 - Updated translations #7474

Development

2 - Update AndroidX Media library to 1.4.x #7148
3 - Deduplicated drawer code in MainActivity #7215
4 - Use the correct TAG in NavigationHelper #7196
8 - Clean up .gitignore files #7264
9 - Remove deprecated setUserVisibleHint #7265
10 - Update pager workaround code to Fragment 1.3.6 #7149
11 - Update some libraries #7263
12 - Update RecyclerView & Groupie libraries #7261
18 - Gradle: Replaced deprecated 'with' with 'using' #7395
20 - Update ExoPlayer to 2.14.2 #7005 and #7408
21 - Remove JCenter #5843
26 - Add gradle wrapper Sha256 #7418 and #7442
27 - Use DefaultLoadcontrol #7406
28 - Some code cleanup(s) #7412
29 - Better player error handling #7142

Changelog of NewPipeExtractor

see TeamNewPipe/NewPipeExtractor#758

@litetex
Copy link
Member Author

litetex commented Nov 30, 2021

litetex's ultimate release checklist:

👉 https://teamnewpipe.github.io/documentation/05_releasing/

Preparing the release

  • Determine the next release versions (major, minor, etc)
  • (if applicable) NPExtractor: Create a release branch in your fork (ensure that your local repo is up-to-date)
    • Increment the version
    • Create a PR to master
    • Create a new draft release (NEXT)
  • Create an issue for the release
  • Update your fork's dev branch so that it matches the upstream one
  • Sync weblate (get the newly translated stuff)
    • In the webinterface Rebase (under update) ⚠️ Do not click Weblate's "push" button
    • Create a new branch on your fork
    • Add the changes from weblate: Checkout your created branch + Add weblate as a remote git remote add weblate https://hosted.weblate.org/git/newpipe/strings/ + Fetch all remotes git fetch --all + Merge the branch git merge weblate/dev + Create a new PR (like Update translations using Weblate #7474)
  • Create a new branch and PR for the changelog file (like Update changelog #7476)
    • Create a changelog file for the next version (max. 400 bytes for translators)
    • Rebase weblate after this was merged
  • Create a release branch in your fork (ensure that your local repo is up-to-date)
    • Ensure that the targeted Extractor version/commit is inside
    • Increment the version
    • Create a PR to master
    • Create a new draft release (NEXT)
  • Add a release candidate to that issue (debug build)
  • Pin the release-issue
  • Notify the blog-writers that there will be a new release

In the meantime (when there is a release candidate but the release itself is not published)

  • Look for any regressions
  • Update the RC accordingly (see above)
  • (optional) Sync weblate

Releasing

  • (if applicable) NPExtractor: Release
    • Merge the PR (You need someone who approves the PR first...)
    • Create a new tag + release
    • Create (and merge) a PR from master to dev to sync them (fast forwarding is also fine - can done by an admin)
  • Ensure the up-to-date NPExtractor version is used
  • Sync weblate (to get the translations of the changelog file) - ⚠️ may have conflicts or new/change/remove string keys that don't fit the current version.
    • Lock weblate before merging because everything is inside of one commit and changes in the meantime may cause merge conflicts
  • Merge the PR (Note: needs an approval from someone else)
  • Sync the changes in the master branch back to dev
    • Create a PR from master to dev (fast forwarding is also fine - can done by an admin)
  • Sync and unlock weblate
  • Build an unsigned APK (gradlew assembleRelease)
  • Send that unsigned APK to @TheAssassin
  • Receive the signed APK; Check the sent back signed APK locally on your device(s)
  • Add the signed APK to the GitHub release draft
  • Check everything again
  • Publish the GitHub release; Create a new tag for the release (should match with the release e.g. v0.12.3) on the master branch
  • Check/Ask TheAssassin if our self hosted F-droid repo is up-to-date
  • Update the website (or ask someone to do so)
  • F-Droid should automatically build and release a version by itself (at around 4:00-6:00 UTC) when a new tag is created

This was referenced Nov 30, 2021
@litetex litetex self-assigned this Nov 30, 2021
@opusforlife2 opusforlife2 pinned this issue Dec 1, 2021
@Tom4tot

This comment has been minimized.

@Stypox
Copy link
Member

Stypox commented Dec 3, 2021

Update the main F-Droid repo

The documentation is probably outdated, but you don't need to do anything to get the new version published on the official F-Droid repo, their automatic updater takes care of adding new versions to the metadata file

@pokegamer5547

This comment has been minimized.

@tsiflimagas

This comment has been minimized.

@pokegamer5547

This comment has been minimized.

@IngwiePhoenix

This comment has been minimized.

@NewNewPipe

This comment has been minimized.

@Stypox

This comment has been minimized.

@litetex
Copy link
Member Author

litetex commented Dec 6, 2021

@CHECK-1234

Your problems are likely caused by the fact that the provided version is a debug version of NewPipe.
I also had this problems but when I built a release version locally and compared the speed it was similar to 0.21.13.

@CHECK-1234
Copy link

@CHECK-1234

Your problems are likely caused by the fact that the provided version is a debug version of NewPipe. I also had this problems but when I built a release version locally and compared the speed it was similar to 0.21.13.

I tested a release from the "Actions" tab that was 0.21.13, and it was a debug apk. When I opened it, it did have the same slow opening speed. You are right, sry if I cause any misunderstandings. I guess the issue was just because of it being a debug version.

@lorenzo9uerra
Copy link

I opened a video and the volume on my earphones was very high, returning to the launcher and then back to newpipe (while the video wqs playing in background) fixed the issue

@Stypox
Copy link
Member

Stypox commented Dec 8, 2021

@lnwor is this caused by this release?

@lorenzo9uerra
Copy link

Yes, it happened just once though, it could be a rare bug or the cause could be the bluetooth earphones. I wanted to report it in case it happened to anyone else

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants