Use custom TextViews and EditTexts in all XML resources #7061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
what's the advantage of showing the native Android share sheet? |
|
See the two first screenshots of #5187 to find the difference: there is no native |
opusforlife2
changed the title
|
I can confirm that this PR makes sharing text use the Android share sheet on EMUI. |
|
Please add documentation to the two new classes explaining why they are needed / used |
litetex
reviewed
Sep 12, 2021
AudricV
force-pushed
the
custom-textview-edittext
branch
from
b1907bc to
12934dc
Compare
@TobiGr Done |
Stypox
previously requested changes
Sep 18, 2021
app/src/main/java/org/schabi/newpipe/views/NewPipeEditText.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/schabi/newpipe/views/NewPipeEditText.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/schabi/newpipe/views/NewPipeTextView.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/schabi/newpipe/views/NewPipeEditText.java
Outdated
Show resolved
Hide resolved
AudricV
force-pushed
the
custom-textview-edittext
branch
2 times, most recently
from
463d175 to
48b3051
Compare
4 tasks
litetex
reviewed
Sep 24, 2021
app/src/main/java/org/schabi/newpipe/views/NewPipeTextView.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/schabi/newpipe/views/NewPipeEditText.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/schabi/newpipe/util/NewPipeTextViewHelper.java
Outdated
Show resolved
Hide resolved
AudricV
force-pushed
the
custom-textview-edittext
branch
from
48b3051 to
a7c1f8d
Compare
AudricV
force-pushed
the
custom-textview-edittext
branch
from
a7c1f8d to
5495cab
Compare
AudricV
requested review from
Stypox and
litetex
and removed request for
Stypox
litetex
requested changes
Oct 2, 2021
app/src/main/java/org/schabi/newpipe/views/NewPipeEditText.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/schabi/newpipe/views/NewPipeEditText.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/schabi/newpipe/views/NewPipeTextView.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/schabi/newpipe/views/NewPipeTextView.java
Outdated
Show resolved
Hide resolved
AudricV
force-pushed
the
custom-textview-edittext
branch
from
5495cab to
5eee81d
Compare
litetex
requested changes
Oct 3, 2021
app/src/main/java/org/schabi/newpipe/util/NewPipeTextViewHelper.java
Outdated
Show resolved
Hide resolved
…the selected text This TextView class extends the AppCompatTextView class from androidx. These changes (only in XML ressources) allow us to share the selected text by using ShareUtils.shareText, which opens the Android system chooser instead of the Huawei system chooser on EMUI devices.
…the selected text This EditText class extends the AppCompatEditText class from androidx. These changes (only in XML ressources) allow us to share the selected text by using ShareUtils.shareText, which opens the Android system chooser instead of the Huawei system chooser on EMUI devices.
Use the same logic as Android TextViews
A new class has been added in the util package: NewPipeTextViewHelper. It shares the selected text of a TextView with ShareUtils#shareText (with the created shareSelectedTextWithShareUtils static method). Only this static method can be used by other classes, other methods are private.
AudricV
force-pushed
the
custom-textview-edittext
branch
from
5eee81d to
ddaafb6
Compare
|
Reminder @Stypox that there is still an open change request that was fixed. |
|
@Stypox sorry, I wanted to dismiss your review, but I requested it by mistake. |
|
Merging this PR seems to have reverted changes made by #6824 (I don't know if it reverted more stuff). |
2 tasks
|
Thank you for letting me know! Looks like I did something bad when I rebased this PR... I opened #7348 to fix this. |
This was referenced Nov 30, 2021
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
TextViews toAppCompatTextViewsEditTexts toAppCompatEditTextsviewsubpackage:NewPipeEditText(which extends fromAppCompatEditText) andNewPipeTextView(extends fromAppCompatTextView).This allows NewPipe to show the Android share sheet on EMUI devices (instead of the EMUI share sheet) when sharing selected text in
TextViews andEditTexts, by usingShareUtils#shareText(Context, String, String).APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence