Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated setUserVisibleHint #7265

Merged
merged 1 commit into from
Oct 18, 2021

Conversation

TacoTheDank
Copy link
Member

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Solves the annoying deprecation :^) (context)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@TacoTheDank TacoTheDank changed the title Get rid of setUserVisibleHint Remove deprecated setUserVisibleHint Oct 16, 2021
@litetex litetex self-requested a review October 17, 2021 12:26
Copy link
Member

@litetex litetex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tested it and seems to work as expected

@TacoTheDank
Copy link
Member Author

TacoTheDank commented Oct 17, 2021

Yeah I tested on my own Android 10 device and tried putting the app in the background, waiting a little bit, and then returning it to the foreground. Everything seems to work as expected.

@litetex litetex added the codequality Improvements to the codebase to improve the code quality label Oct 17, 2021
@litetex litetex merged commit 231b749 into TeamNewPipe:dev Oct 18, 2021
@TacoTheDank TacoTheDank deleted the userVisibleHintBGone branch October 18, 2021 18:52
@opusforlife2
Copy link
Collaborator

Great branch name. xD

This was referenced Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codequality Improvements to the codebase to improve the code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants