Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DefaultLoadcontrol #7406

Merged
merged 1 commit into from
Nov 21, 2021
Merged

Conversation

Redirion
Copy link
Member

@Redirion Redirion commented Nov 14, 2021

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

The custom LoadController of NewPipe basically had two differences to the DefaultLoadcontrol of ExoPlayer:

  • the start/resume buffer was only 500ms instead of 2500ms and
  • there was a customized condition to start the playback depending on the speed. We now only use ExoPlayers behaviour / values.

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@AudricV AudricV added feature request Issue is related to a feature in the app player Issues related to any player (main, popup and background) labels Nov 14, 2021
Copy link
Member

@litetex litetex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I like a PR that actually removes code instead of adding some - Easier to maintain 😄

Some long(er) time testing should be done before merging this.

@litetex
Copy link
Member

litetex commented Nov 21, 2021

Did some longer testing and seems to work as expected. Merging.

@litetex litetex merged commit d8236bb into TeamNewPipe:dev Nov 21, 2021
This was referenced Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app player Issues related to any player (main, popup and background)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants