Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove JCenter when possible #5843

Merged
merged 1 commit into from
Nov 12, 2021
Merged

Remove JCenter when possible #5843

merged 1 commit into from
Nov 12, 2021

Conversation

TobiGr
Copy link
Contributor

@TobiGr TobiGr commented Mar 16, 2021

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

The JCenter repository is going to be shut down. This PR tries to resolve as many dependencies as possible from other repositories.

Fixes the following issue(s)

#5837

APK testing

On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.

Due diligence

@TobiGr TobiGr added the meta Related to the project but not strictly to code label Mar 16, 2021
@TobiGr TobiGr mentioned this pull request Mar 16, 2021
Closed
4 tasks
@TobiGr TobiGr linked an issue Mar 16, 2021 that may be closed by this pull request
Jcenter will shut down soon #5837
Closed
4 tasks
@triallax triallax added the ASAP Issue needs to be fixed as soon as possible label Mar 19, 2021
@sonarqubecloud

This comment has been minimized.

Sign in to view
@jimman2003
Copy link
Contributor

jimman2003 commented May 4, 2021 •
edited
Loading

@TobiGr, try pulling groupie from jitpack! I have done it at my own fork..
Github repo of groupie:https://github.com/lisawray/groupie
implementation 'com.github.lisawray.groupie:groupie:2.8.1' seem to work
P.S haven't made it to work with groupie-viewbinding: private in jitpack

@jimman2003
Copy link
Contributor

jimman2003 commented May 4, 2021 •
edited
Loading

Also exoplayer from google's repo

@TobiGr TobiGr mentioned this pull request Jun 21, 2021
Merged
5 tasks
@litetex
Copy link
Member

litetex commented Sep 3, 2021

@TobiGr
What's the progress here?
trove4j is now on Maven central -> https://youtrack.jetbrains.com/issue/IDEA-261387

So I think we can drop jcenter completely

Also somehow the build seems to be messed up. Maybe rebase?

@litetex litetex added the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Oct 13, 2021
@litetex
Copy link
Member

litetex commented Oct 13, 2021

Friendly reminder that this is still a thing.

@AudricV AudricV removed the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Oct 16, 2021
@litetex
Copy link
Member

litetex commented Oct 16, 2021

Build failure is due to

Cause 1: org.gradle.internal.resolve.ModuleVersionNotFoundException: Could not find com.google.android.exoplayer:exoplayer:2.12.3.
Cause 2: org.gradle.internal.resolve.ModuleVersionNotFoundException: Could not find com.google.android.exoplayer:extension-mediasession:2.12.3.

Exoplayer 2.12.3 is not published at https://maven.google.com/:
https://mvnrepository.com/artifact/com.google.android.exoplayer/exoplayer

Only versions >= 2.13.3 are

@litetex litetex mentioned this pull request Nov 7, 2021
Merged
5 tasks
@TobiGr @litetex
Remove JCenter
605b8fa 
All dependencies which were fetched from JCenter are now available via Maven Central. This source change is necessary becuase JCenter announced they werer going to be read-only starting at 31st March 2021 (https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter).
@litetex
Copy link
Member

litetex commented Nov 12, 2021

ExoPlayer is now on 2.14.2 so let's see if we can get a green build...

@litetex litetex marked this pull request as ready for review November 12, 2021 19:50
@litetex litetex self-requested a review November 12, 2021 19:51
litetex
litetex approved these changes Nov 12, 2021
View reviewed changes
Copy link
Member

@litetex litetex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is green 🥳

@litetex litetex merged commit e39a816 into dev Nov 12, 2021
@litetex litetex deleted the jcenter branch November 12, 2021 19:53
This was referenced Nov 30, 2021
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@litetex litetex litetex approved these changes

Assignees
No one assigned
Labels
ASAP Issue needs to be fixed as soon as possible meta Related to the project but not strictly to code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Jcenter will shut down soon
5 participants
@TobiGr @jimman2003 @litetex @triallax @AudricV