Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jcenter will shut down soon #5837

Closed
4 tasks done
Atemu opened this issue Mar 15, 2021 · 3 comments · Fixed by #5843
Closed
4 tasks done

Jcenter will shut down soon #5837

Atemu opened this issue Mar 15, 2021 · 3 comments · Fixed by #5843
Labels
ASAP Issue needs to be fixed as soon as possible bug Issue is related to a bug meta Related to the project but not strictly to code

Comments

@Atemu
Copy link
Contributor

Atemu commented Mar 15, 2021

I wanted to build NewPipe today but there's a jcenter outage and I'm unable to fetch the dependencies.

When googling for potential mirrors, I found this: https://blog.gradle.org/jcenter-shutdown

O_o

I wasn't even able to fetch the kotlin plugin with a clean GRADLE_USER_HOME. It's in mavenCentral too thankfully but even with that I get stuck at trove4j which isn't in mavenCentral nor Google's repo.

Apparently jcenter will go readonly at the end of the month, so this patch will need to be made to work rather soon if we want security patches from that point on:

diff --git a/build.gradle b/build.gradle
index b2593ab42..4f23e4b5e 100644
--- a/build.gradle
+++ b/build.gradle
@@ -3,7 +3,6 @@
 buildscript {
     ext.kotlin_version = '1.4.10'
     repositories {
-        jcenter()
         google()
     }
     dependencies {
@@ -17,7 +16,6 @@ buildscript {
 
 allprojects {
     repositories {
-        jcenter()
         google()
         maven { url "https://jitpack.io" }
         maven { url "https://clojars.org/repo" }
-- 

Checklist

Steps to reproduce the bug

Actual behaviour

Expected behavior

Screenshots/Screen recordings

Logs

Device info

  • Android version/Custom ROM version:
  • Device model:
@Atemu Atemu added the bug Issue is related to a bug label Mar 15, 2021
@TobiGr TobiGr added the ASAP Issue needs to be fixed as soon as possible label Mar 15, 2021
@AudricV AudricV added the meta Related to the project but not strictly to code label Mar 15, 2021
@TobiGr
Copy link
Contributor

TobiGr commented Mar 16, 2021

Thank you for letting us know!
I have created PR to remove JCenter when possible: #5843
I could not resolve these dependencies:

com.google.android.exoplayer:exoplayer:2.11.8
com.google.android.exoplayer:extension-mediasession:2.11.8
com.nononsenseapps:filepicker:4.2.1
com.xwray:groupie:2.8.1
com.xwray:groupie-viewbinding:2.8.1
org.jetbrains.trove4j

Most of these already work on publishing their binaries on other platforms:

@Atemu Were you able to resolve any of those dependencies?

@TobiGr TobiGr linked a pull request Mar 16, 2021 that will close this issue
5 tasks
@Atemu
Copy link
Contributor Author

Atemu commented Mar 17, 2021

My attempts didn't go much further than trying to get stuff from mavenCentral() instead either.

For some dependencies like trove, jcenter going readonly might not be that bad as it hasn't seen an update in years anyways.
Your approach of explicitly whitelisting these is the best we could do right now I think.

@OxygenCobalt
Copy link
Contributor

OxygenCobalt commented Apr 14, 2021

@TobiGr Looks like Exoplayer and trove4j have both moved to GMaven/mavenCentral. You may want to update #5843 to reflect that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASAP Issue needs to be fixed as soon as possible bug Issue is related to a bug meta Related to the project but not strictly to code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants