Missing strings (Weblate)

[nadiration]

Checklist

• I am using the latest version - x.xx.x
• I checked, but didn't find any duplicates (open OR closed) of this issue in the repo.
• I have read the contribution guidelines given at https://github.com/TeamNewPipe/NewPipe/blob/HEAD/.github/CONTRIBUTING.md.
• This issue contains only one bug. I will open one issue for every bug report I want to file.

Steps to reproduce the bug

1. Search any video and the published time/date (e.g 18 hours ago, 1day/month/year ago) of the content is stuck with English even though you switched the language (in this case Somali) Edit: This happened to be social date formatter PrettyTime which NewPipe uses so I translated the language for the project. This is SOLVED.
2. "Next" on video page acts the same way.
3. "Cancel" key on the app language picker (edit: and some other places i just found out) is the same although cancel in other places of the app is translated fine.
   Edit: the cancel not being translated button isn't limited to language picker but also on other places like creating new chanel groups

See screenshots for context.

Actual behaviour

"Next" on video page isn't following the app language, that's due to "Next" string missing from translation strings on Weblate.

The "Cancel" key on the app language picker and some other places in the app.

Expected behavior

Complete strings on Weblate for the app to be consistent.

Screenshots/Screen recordings

*on search (published time) Edit: SOLVED.

*on video page ("Next")

*on creating new chanel groups and some other places ("Cancel") :

@TobiGr

[TobiGr]

@Stypox any idea, why exo_controls_next_description is used? I did not noticed, that it was changed.
I suggest to use something different, because "next track" is not always true (e.g. the queue can contain other streams which are up next). What about "related content" or "similar content" or "related streams"?

About the upload time: that seems to be a bug, because some lib should be responsible for that.

[nadiration]

@Stypox any idea, why exo_controls_next_description is used? I did not noticed, that it was changed.
I suggest to use something different, because "next track" is not always true (e.g. the queue can contain other streams which are up next). What about "related content" or "similar content" or "related streams"?

About the upload time: that seems to be a bug, because some lib should be responsible for that.

The "Cancel" key on the app language picker is also the same although cancel is translated fine on other places in the app.

I agree with you on not using "next track", related content" or "similar content" or "related streams" are all way better.

[TobiGr]

In the content settings? That is a standard android dialog We cannot change that.

[nadiration]

In the content settings? That is a standard android dialog We cannot change that.

The cancel button on the bottom of the languages list on Settings > Contents > App language. I just checked with some other languages and it changes on some of the languages and for some it just stays cancel.

[TobiGr]

I guess that depends on the languages which are installed on your device.

[Stypox]

@TobiGr 11e048a is the responsible commit: I assumed that the exoplayer strings were translated in all languages. I just tried a couple of languages and the strings were all translated, but apparently ExoPlayer does not fully support Somali (i.e. some strings are translated, some others not). The commit should probably be reverted.

[XiangRongLin]

@nadiration It's the android cancel. see line 210 and 218

NewPipe/app/src/main/res/layout/dialog_feed_group_create.xml

Lines 204 to 218 in 9a65f02

	<Button
	android:id="@+id/cancel_button"
	style="?buttonBarButtonStyle"
	android:layout_width="wrap_content"
	android:layout_height="wrap_content"
	android:layout_toStartOf="@+id/confirm_button"
	android:text="@android:string/cancel" />
	<Button
	android:id="@+id/confirm_button"
	style="?buttonBarButtonStyle"
	android:layout_width="wrap_content"
	android:layout_height="wrap_content"
	android:layout_alignParentEnd="true"
	android:text="@string/create" />

[XiangRongLin]

@nadiration the "cancel" is an android string (prefixed with android), the create is our own one (prefixed with string). So i would assume the same thing that TobiGr said:

I guess that depends on the languages which are installed on your device.

[nadiration]

@XiangRongLin Can we use our own "cancel" string instead of prefixed android string?

@nadiration the "cancel" is an android string (prefixed with android), the create is our own one (prefixed with string).

[XiangRongLin]

I'm against it. This should be fixed in Android not from us. Using our own would require translating it for all languages

[nadiration]

@TobiGr, @XiangRongLin , @Stypox I fixed the date/time display as it was PrettyTime social date structure missing Somali language so I translated the language for the project and now it works fine. Now the remaining problems are "Next" and "Cancel" key. the "Cancel" string which is still stuck with Android prefixed string. This makes the app inconsistent and it's really confusing some old people i know that only know Somali and use the app regularly. They always ask me about it and it confuses them. As @Stypox mentioned this can be fixed by reverting the commit he mentioned or simply using our own local string.
Please consider this. Thank you for your attention.

[Stypox]

The "Next" string should be fixed by exoplayer, not us. Maybe we could add the "Cancel" string, as it's just one string.

[nadiration]

The "Next" string should be fixed by exoplayer, not us. Maybe we could add the "Cancel" string, as it's just one string.

@Stypox yeah man ok. Please fix the cancel string it's tiny but very important for us.

[Stypox]

Oh, the cancel string was actually already included in the translated strings in newpipe, we were just using the incorrect string in some places

[Stypox]

#6848 @nadiration