Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace R.string.yes with R.string.ok #7976

Merged
merged 1 commit into from
Mar 3, 2022

Conversation

Stypox
Copy link
Member

@Stypox Stypox commented Mar 2, 2022

Android doesn't use yes/no but ok/cancel usually, so this should be done here, too

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Related info

This can be considered a followup to #7024. I thought all yes were replaced by ok in that PR, but apparently it was not the case (as I could notice in #5878), hence this PR.

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

Android doesn't use yes/no but ok/cancel usually, so this should be done here, too
@Stypox Stypox changed the title Replace R.string.yes with R.string.ok Replace R.string.yes with R.string.ok Mar 2, 2022
@Stypox Stypox changed the title Replace R.string.yes with R.string.ok Replace R.string.yes with R.string.ok Mar 2, 2022
@Stypox Stypox changed the title Replace R.string.yes with R.string.ok Replace R.string.yes with R.string.ok Mar 2, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@AudricV AudricV added the localisation / translation Everything that has to do with translations or Weblate label Mar 2, 2022
@litetex litetex added the codequality Improvements to the codebase to improve the code quality label Mar 2, 2022
Copy link
Member

@litetex litetex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Redirion
Copy link
Member

Redirion commented Mar 3, 2022

We could use https://developer.android.com/reference/android/R.string#ok

edit: android.R.string.ok is actually "OK". So if lower case is intended it's not usable.

@AudricV
Copy link
Member

AudricV commented Mar 3, 2022

No, we can't for some languages: see the PR linked and #5454.

@Stypox Stypox merged commit 05a5e43 into TeamNewPipe:dev Mar 3, 2022
@Redirion
Copy link
Member

Redirion commented Mar 3, 2022

ok yeah but that was regarding the well known "cancel". But anyway :)

@Stypox Stypox mentioned this pull request Apr 16, 2022
12 tasks
@Stypox Stypox deleted the remove-yes-string branch August 4, 2022 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codequality Improvements to the codebase to improve the code quality localisation / translation Everything that has to do with translations or Weblate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants