Release 0.23.0 (please TEST!)

[Stypox]

Testing for regressions

Debug APK (built by our CI in #8231): NewPipe_0.23.0_RC2.zip
Release APK (signed with Stypox's keys): NewPipe_0.23.0_RC2.zip
Please report only regressions (i.e. new issues) here, not issues that were already present in the previous release!

TODO

• Merge Weblate
• Unlock Weblate when 0.23.0 is released
• Possibly including @TiA4f8R's extractor improvement to solve potential future throttling issues
  • In this case a new NewPipeExtractor version needs to be released,
  • and the extractor commit should be updated in the gradle dependencies.
• Possibly see if Slow initial video buffer #7630 can be solved in this release
  • Use 64 KiB as the default progressive load interval #8302
• Fix new streams notifications preference screen #8233
• Fix proguard for notification preference fragment #8236
• Fix crash when open NewPipe from notification bar #8244
• Fix disabled caption to no longer automatically re-enable on new player instance #8249
• DEFINITELY Adapt opacity of popup close button to allow touches in other apps on Android >=12 #8279

NewPipeExtractor version

This version of NewPipe will ship with NewPipeExtractor version 0.22.1

App changelog

New

• Add seamless transition between background and video players when putting the app in background (for video-only streams and audio-only streams only) Add seamless transition between background and video players when putting the app in background (for video-only streams and audio-only streams only) #7349 Fix fetch of video streams (when switching between tracks in a play queue) and subtitles when using a seamless transition between background and video players #8139
• Change pitch by semitones Change pitch by semitones #7565
• Implement appending queue to playlist in main player Implement appending queue to playlist in main player #8008
• New streams notifications New streams notifications #2335
• Load YouTube mixes in related items Add MixInfoItem and extract YouTube mixes in related items NewPipeExtractor#788 -- note that this has already been broken by YouTube

Improved

• Remember adjustment step size for playback controls (speed and pitch) Remember adjustment step size for playback controls (speed and pitch) #7728
• Mitigating long buffering on initial video playback Mitigating long buffering on initial video playback #7919
• Replace R.string.yes with R.string.ok Replace R.string.yes with R.string.ok #7976
• Improve player UI and navigability for Android TV Improve player UI and navigability for Android TV #7963
• Add a confirmation button when deleting all files in downloader Add a confirmation button when deleting all files in downloader #5878
• ExoPlayer 2.17.1 update and MediaSource management rework ExoPlayer 2.17.1 update and MediaSource management rework #8020 Fix caption auto-selection not reflected in player GUI #8150

Fixed

• Fix player controls not hiding if resumed from media button Fix player controls not hiding if resumed from media button #7341
• Migrate app update checker to AndroidX Work Migrate app update checker to AndroidX Work #7975
• Fix error notification on KitKat Fix error notification on KitKat #7977
• Fix playback being reset to beginning when player type was changed ExoPlayer 2.17.1 update and MediaSource management rework #8020
• Fix download dialog selector layout Fix download dialog selector layout #7516
• Fix crash when rotating device with playlist dialog open Use newInstance in PlaylistDialog #8146
• Adapt opacity of popup close button to allow touches in other apps on Android >=12 Adapt opacity of popup close button to allow touches in other apps on Android >=12 #8279

Development

• Replace CircleImageView with ShapeableImageView Replace CircleImageView with ShapeableImageView #7925
• Solve Java warning Raw use of parameterized class Solve Java warning "Raw use of parameterized class" #7904
• Fix Room warning about unused columns during build Fix Room warning about unused columns during build #7905
• Fix build on Apple Silicon Macs Fix build on Apple Silicon macs #7782
• Refactor generating InfoItemDialog's Refactor generating InfoItemDialog's #7570
• Better equals check Better equals check #7910
• Update Android Gradle Plugin and Gradle Update AGP and Gradle #7947
• Remove duplicate large-land player layout Remove large-land player layout: not actually used #7894
• Update ConstraintLayout and Room libraries Update ConstraintLayout, Room libraries #7954
• Update Kotlin to 1.6.10 Update Kotlin to 1.6.10 #7952
• Update some AndroidX libraries Update some AndroidX libraries #7978
• Remove icon duplicates and fix some theming issues Remove icon duplicates and fix some theming issues #7518 Remove pin and notifications night icons #8081
• Deduplicate code for fetching stream info when sparse Deduplicate code for fetching stream info when sparse #7981 Fix SparseItemUtil so we don't enqueue twice #8127
• Extract some view click listeners from player Extract view click listeners from Player #8011
• Delete some unused code Delete some unused code #8067
• Clean up the about package a bit Clean up the about package a bit #8065
• Create stub implementation for OnSeekBarChangeListener Create stub implementation for OnSeekBarChangeListener #8066
• Some lint cleaning Some lint cleaning #8068
• Update Checkstyle to 10.0 and fix various related issues Update checkstyle to 10.0 and fix various related issues #8073
• Update license to latest version Update license to latest version #8076 Delete copyright-file #8077
• Update CONTRIBUTING.md with current checkstyle.xml path Update CONTRIBUTING.md with current checkstyle.xml path #8175
• Updated extractor to latest version of the dev-branch Updated extractor to latest version of the dev-branch #8191
• Update GitHub action dependencies in workflows Update action dependencies in workflows #8198
• Update AGP, Gradle, and Kotlin Update AGP, Gradle, and Kotlin #8204
• Use simpler DrawerLayout method Use simpler DrawerLayout method #8200
• Replace checklist drawable Replace checklist drawable #8199

[Stypox]

@tsiflimagas reported this crash on IRC, it happens in the release build when tapping on Channels in the New stream notifications settings.
Edit: fixed by #8236

Crash log

Exception

• User Action: ui error
• Request: ACRA report
• Content Language: en-GB
• Service: none
• Version: 0.23.0
• OS: Linux Android 10 - 29

androidx.fragment.app.Fragment$InstantiationException: Unable to instantiate fragment org.schabi.newpipe.settings.notifications.NotificationModeConfigFragment: make sure class name exists
	at androidx.fragment.app.FragmentFactory.loadFragmentClass(FragmentFactory.java:97)
	at androidx.fragment.app.Fragment.instantiate(Fragment.java:611)
	at androidx.fragment.app.FragmentContainer.instantiate(FragmentContainer.java:57)
	at androidx.fragment.app.FragmentManager$3.instantiate(FragmentManager.java:483)
	at org.schabi.newpipe.settings.SettingsActivity.instantiateFragment(SettingsActivity.java:181)
	at org.schabi.newpipe.settings.SettingsActivity.onPreferenceStartFragment(SettingsActivity.java:174)
	at androidx.preference.PreferenceFragmentCompat.onPreferenceTreeClick(PreferenceFragmentCompat.java:422)
	at androidx.preference.Preference.performClick(Preference.java:1208)
	at androidx.preference.Preference.performClick(Preference.java:1182)
	at androidx.preference.Preference$1.onClick(Preference.java:182)
	at android.view.View.performClick(View.java:7259)
	at android.view.View.performClickInternal(View.java:7236)
	at android.view.View.access$3600(View.java:801)
	at android.view.View$PerformClick.run(View.java:27892)
	at android.os.Handler.handleCallback(Handler.java:883)
	at android.os.Handler.dispatchMessage(Handler.java:100)
	at android.os.Looper.loop(Looper.java:214)
	at android.app.ActivityThread.main(ActivityThread.java:7356)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:491)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:940)
Caused by: java.lang.ClassNotFoundException: org.schabi.newpipe.settings.notifications.NotificationModeConfigFragment
	at java.lang.Class.classForName(Native Method)
	at java.lang.Class.forName(Class.java:454)
	at androidx.fragment.app.FragmentFactory.loadClass(FragmentFactory.java:53)
	at androidx.fragment.app.FragmentFactory.loadFragmentClass(FragmentFactory.java:94)
	... 20 more
Caused by: java.lang.ClassNotFoundException: org.schabi.newpipe.settings.notifications.NotificationModeConfigFragment
	... 24 more

[litetex]

Possibly see if #7630 can be solved in this release

I think we have some kind of buffering problem which now affects all streams (until 0.23.0 it only affected YT 60fps streams). I created a new issue for that: #8238

[karyogamy]

Found another issue in #8150: After selecting No Caption before closing a player instance, open a new next player instance, and its track selector will automatically select a caption, even if caption is disabled as mentioned.

[SameenAhnaf]

2. When system dark mode is enabled, a lot of components lack contrast. This isn't the case when theme is changed from app settings.

Screen recording

Screenrecorder-2022-04-18-23-47-32-352.mp4

First bug is removed as it was reproducible in previous app versions

[gardockt]

After a new upload I received a notification not only about this video, but also about 2 other videos on different channels, both uploaded months ago - one of which was not even a last upload on the channel. That happened on RC2, on a first automatic refresh.

[Stypox]

When system dark mode is enabled, a lot of components lack contrast. This isn't the case when theme is changed from app settings.

@SameenAhnaf sorry, I don't understand what you mean. Can you take a screenshot and make a circle around what you think is not colored correctly? Or could you tell me which icons are wrong? I don't see a problem in your video

After a new upload I received a notification not only about this video, but also about 2 other videos on different channels, both uploaded months ago - one of which was not even a last upload on the channel. That happened on RC2, on a first automatic refresh.

@gardockt This can happen on the first refresh, since the database might miss some videos the first time. Please let us know if this keeps happening even after the first refresh, as that would really be a problem.

[Stypox]

I would like to release tomorrow, almost everything should be ready.

Possibly including @TiA4f8R's extractor improvement to solve potential future throttling issues

@TiA4f8R could you open a PR or delegate that to me? If I understood correctly it is just a simple change (replacing a HashMap with a List), so I can do that myself in a few minutes (unless I'm not understanding something correctly)

DEFINITELY

The only reason I said "maybe" was because the fastlane changelog does not include that change, but we would like users to know about such an important change. Maybe we should include it in the next release changelog, so that at least people can know by looking at the changelog?

When system dark mode is enabled, a lot of components lack contrast. This isn't the case when theme is changed from app settings.

This is still not fixed, but I still don't understand what needs to be solved. I don't see anything badly-themed, except maybe the brightness/volume, but I am not sure. @SameenAhnaf

[SameenAhnaf]

@Stypox Extremely sorry for the late reply. Following components lack contrast.

1. Brightness and Volume sliders
2. Subscribe icon
3. Feed update bar

Stable Version	Version 0.23.0_RC2
Before.mp4	After.mp4

[Stypox]

@SameenAhnaf ok, thank you, I could see the differences by pausing the videos at the same time. What is happening is really strange, since I cannot reproduce on an emulator. Maybe there is a bug in your ROM or something like that, since NewPipe's code does the same thing (i.e. calling setTheme(BlackTheme)) both when the theme selection is done automatically or not. So I would not focus on this really small bug and release even in its presence. But thank you @SameenAhnaf for noticing, please open an issue and we can ask @mauriciocolli to look into this (he is the author of #7518) :-)

[opusforlife2]

Maybe we should include it in the next release changelog, so that at least people can know by looking at the changelog?

@Stypox Can the current changelog not be edited?

[Stypox]

@opusforlife2 the English one, yes, the translated ones no, since we don't know all languages. I would just include that change in the next changelog.

[moriel5]

I'll test streaming in a bit, however on version 0.23 downloads are still throttled for me in the same manner as on 0.22.2, regardless of which stream is being requested.

[Stypox]

There has been no changes about throttling between 0.22.2 and 0.23.0

[moriel5]

@Stypox Ah, sorry for misunderstanding then, it simply sounded as though a solution was found on the blog post.