Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update license to latest version #8076

Merged
merged 1 commit into from
Mar 19, 2022
Merged

Conversation

litetex
Copy link
Member

@litetex litetex commented Mar 19, 2022

What is it?

  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Updates the license to the latest version of https://www.gnu.org/licenses/gpl-3.0.txt
This way also GitHub recognizes the License correctly:
It should look like this after merging this PR:
grafik
grafik

Due diligence

@litetex litetex added the meta Related to the project but not strictly to code label Mar 19, 2022
@litetex litetex changed the title Update license to latest version of https://www.gnu.org/licenses/gpl-3.0.txt Update license to latest version Mar 19, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@litetex litetex merged commit 8c5e8bd into TeamNewPipe:dev Mar 19, 2022
@litetex litetex deleted the update-license branch March 19, 2022 16:58
@TobiGr
Copy link
Contributor

TobiGr commented Mar 19, 2022

The license is still not properly recognized:
grafik

@litetex
Copy link
Member Author

litetex commented Mar 19, 2022

The license is still not properly recognized: ...

https://stackoverflow.com/questions/66258037/github-license-not-recognised
https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/licensing-a-repository#detecting-a-license

root@d9e046c88310:/app# licensee detect .
License:        NOASSERTION
Matched files:  LICENSE, copyright, README.md
LICENSE:
  Content hash:  7d4cdf499d39e2e1ce27b2878e22872f0f5a74dd
  Confidence:    100.00%
  Matcher:       Licensee::Matchers::Exact
  License:       GPL-3.0
copyright:
  Content hash:  292bc3bb9228726147ae822cb1941bd83a0c3680
  License:       NOASSERTION
  Closest non-matching licenses:
    0BSD similarity:  30.08%
    ISC similarity:   28.19%
    Zlib similarity:  26.23%
README.md:
  Content hash:  8aa4b4336e12b69cec2eee536f7e84c0f83c6f0d
  Confidence:    90.00%
  Matcher:       Licensee::Matchers::Reference
  License:       GPL-3.0
  Closest non-matching licenses:
    WTFPL similarity:  22.92%
    0BSD similarity:   13.02%
    Zlib similarity:   11.30%

Why the hell is there a copyright file?

Create a new PR for fixing this: #8077

@litetex litetex mentioned this pull request Mar 19, 2022
2 tasks
@Stypox Stypox mentioned this pull request Apr 16, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Related to the project but not strictly to code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants