Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update some AndroidX libraries #7978

Merged
merged 2 commits into from
Mar 15, 2022
Merged

Conversation

TacoTheDank
Copy link
Member

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Taking out the lesser bumps here. As always, be sure to read the changelogs (including the beta releases leading up to it).

I added size change differences for release APK builds.

  • Update AndroidX LocalBroadcastManager 1.0.0 -> 1.1.0 (changelog) (this should eventually be replaced as it is a formal deprecation, but there's no harm in updating it right now) (no size change)
  • Update AndroidX Media 1.4.3 -> 1.5.0 (changelog) (drops 4 KB)
  • Update AndroidX Preference 1.1.1 -> 1.2.0 (changelog) (adds 25 KB)
  • Update Google Material 1.4.0 -> 1.5.0 (changelog) (adds 224 KB (bruh))
    • This includes an AndroidX DrawerLayout bump from 1.0.0 -> 1.1.1 (changelog)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@Stypox
Copy link
Member

Stypox commented Mar 3, 2022

this should eventually be replaced as it is a formal deprecation, but there's no harm in updating it right now

Right. Would it be doable to replace it with LiveData in NewPipe?

Update Google Material 1.4.0 -> 1.5.0

They seem to have switched to Material 3, maybe that's the reason for the change in size

@TacoTheDank
Copy link
Member Author

Right. Would it be doable to replace it with LiveData in NewPipe?

Yes; however, that is something I'd rather have done in a different PR.

They seem to have switched to Material 3, maybe that's the reason for the change in size

Probably, yeah.

@TacoTheDank TacoTheDank added the codequality Improvements to the codebase to improve the code quality label Mar 6, 2022
@TacoTheDank
Copy link
Member Author

I'm interested in moving this PR forward so I can start working on the other AndroidX updates as well as the MaterialComponents migration. I've already started somewhat, but I'd like for the MaterialComponents library to be at 1.5.0 in the dev branch so I can rebase my migration-branch on it.

So, any updates?

@litetex litetex self-requested a review March 14, 2022 17:10
Copy link
Member

@litetex litetex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Did a quick (smoke) test and everything works fine.
Emulator: Android 11 (API: 30) - Pixel 3a

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@litetex litetex merged commit 6fe6f4b into TeamNewPipe:dev Mar 15, 2022
@TacoTheDank TacoTheDank deleted the bumpSomeLibraries branch March 16, 2022 15:04
@TacoTheDank TacoTheDank mentioned this pull request Apr 14, 2022
5 tasks
@Stypox Stypox mentioned this pull request Apr 16, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codequality Improvements to the codebase to improve the code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants