Migrate app update checker to AndroidX Work

[TacoTheDank]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

IntentService is deprecated, so I migrated to what was supposed to be its replacement (JobIntentService, which is also now deprecated), and then I migrated to AndroidX Work (which is now the recommended replacement).

Unfortunately this means yet another library, but it is what it is. Overall, this change only adds around 101 KB to the release build.

1. I moved the utility methods out of the service class to make it smaller because that stuff didn't really belong in there. Also I cleaned up some parameters.
2. Convert the new utility class to Kotlin so I can merge it together with NewVersionManager.
3. Migrate the IntentService to what was supposed to be its replacement (JobIntentService). This itself would be enough to fix CheckForNewAppVersion randomly fails (when app is in background) #7397. However, I wanted to go further. This is because JobIntentService is also terrible in general and has an infamous crashing bug on API 26. Also it's deprecated (lol). So...
4. Convert this Service class into a Worker. Workers are what we are now supposed to use. Also I renamed the class to make more sense.
5. Converted this new Worker class to Kotlin.

I tested these changes on API 29. I checked the manual update button in settings and it works.

Here's more info:

• https://developer.android.com/topic/libraries/architecture/workmanager
• https://developer.android.com/reference/androidx/work/WorkManager

Here's another PR in which I made this change: AntennaPod/AntennaPod#5742

Fixes the following issue(s)

• Fixes CheckForNewAppVersion randomly fails (when app is in background) #7397 (I believe)

APK testing

app-release updateCheckerWorker.zip

This is a specially generated APK where the isReleaseApk() method always returns true (thus guaranteeing that the update notification will always be displayed). Also the applicationId is slightly changed to allow side-by-side installation. This is only for testing purposes.

Due diligence

• I read the contribution guidelines.

[Stypox]

and then I migrated to AndroidX Room

I assume this is a typo and you meant AndroidX Work

Unfortunately this means yet another library, but it is what it is.

I think that's not a big issue, since AndroidX Work was going to be added anyway by #2335

[TacoTheDank]

I assume this is a typo and you meant AndroidX Work

Damn, and I checked it over like three times too LOL, fixed

I think that's not a big issue, since AndroidX Work was going to be added anyway by #2335

👍

[Stypox]

Thank you! Note: this should be tested well, otherwise we might encounter the same problems that forced us to do 2 hotfix releases in a row a while ago ;-)

[TacoTheDank]

Updated the attached testing APK.

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
1 Security Hotspot
0 Code Smells

0.0% Coverage
0.0% Duplication

[TacoTheDank]

Any updates on this?

[Stypox]

I tested on API 19 and API 31 three different situations (last update check expired -> notification, last update check not expired -> nothing, manual update check -> notification) and I can confirm it works. Thank you and sorry for the delay :-)