Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix download dialog selector layout #7516

Merged
merged 3 commits into from
Apr 2, 2022

Conversation

mauriciocolli
Copy link
Contributor

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Some logic was missing in the adapter for making the no-audio icon GONE instead of INVISIBLE. I fixed it and added some tests as well.

That reveals another problem: some icons are not themed properly, I will fix that in another pull request.

Fixes the following issue(s)

Due diligence

@mauriciocolli mauriciocolli added bug Issue is related to a bug GUI Issue is related to the graphical user interface labels Dec 8, 2021
Copy link
Member

@litetex litetex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks on the first impression good.
👍 for the tests

However I would appreciate some (there is currently zero) documentation like JavaDoc or comments.

@mauriciocolli mauriciocolli force-pushed the fix-download-dialog-selector branch from 363c37a to 065f9df Compare December 10, 2021 16:06
@mauriciocolli
Copy link
Contributor Author

Done.

Copy link
Member

@litetex litetex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

However I'm unable to get a situation where the icon is visible in the first place.

@mauriciocolli
Do you know a situation/video where that's the case?

* @return if there are any video-only streams with no secondary stream associated with them.
* @see #hasVideoOnlyWithNoSecondaryStream
*/
private boolean checkHasVideoOnlyWithNoSecondaryStream() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rename that method to checkHasAnyVideoOnlyStreamWithNoSecondaryStream

@litetex litetex added the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Jan 21, 2022
@litetex litetex force-pushed the fix-download-dialog-selector branch from 065f9df to 99d6238 Compare April 2, 2022 13:25
@litetex litetex self-assigned this Apr 2, 2022
@litetex
Copy link
Member

litetex commented Apr 2, 2022

Since there is no feedback for over 2-3 months now (seriously guys stop doing fire-and-forget PRs 😾), I fixed it myself:

  • Rebased the PR
  • Applied changes
  • Fixed tests
  • The UI works now as expected:
    Modified hasSecondaryStream so that it always returns false - only locally for testing purposes (because I couldn't find any stream that has no audio):
    grafik grafik

@litetex litetex removed the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Apr 2, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@litetex litetex merged commit 629b685 into TeamNewPipe:dev Apr 2, 2022
@Stypox Stypox mentioned this pull request Apr 16, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug GUI Issue is related to the graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In Download Dialog UI, margin is not even
2 participants