Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SparseItemUtil so we don't enqueue twice #8127

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

litetex
Copy link
Member

@litetex litetex commented Mar 30, 2022

What is it?

  • Bugfix (user facing)

Description of the changes in your PR

Fix SparseItemUtil loading

  • Added a missing return statement
  • fetchUploaderUrlIfSparse now has a similar code-layout to fetchItemInfoIfSparse

In #8020 (review) I noticed that the enqueuing function enqueues streams twice.

The problem was introduced in #7981 and I didn't noticed it until now.

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

* Added a missing `return` statement
* `fetchUploaderUrlIfSparse` now has a similar layout to `fetchItemInfoIfSparse`
@litetex litetex added the bug Issue is related to a bug label Mar 30, 2022
@AudricV AudricV added the player Issues related to any player (main, popup and background) label Mar 30, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@opusforlife2 opusforlife2 changed the title Fix SparseItemUtil Fix SparseItemUtil so we don't enqueue twice Apr 1, 2022
Copy link
Member

@AudricV AudricV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the changes and it works as excepted. Thank you!

Code looks good to me.

@Redirion
Copy link
Member

Redirion commented Apr 7, 2022

I trust TiA4f8R' review, code looks good

@Redirion Redirion merged commit a528cee into TeamNewPipe:dev Apr 7, 2022
@litetex litetex deleted the fix-SparseItemUtil branch April 9, 2022 20:03
@Stypox Stypox mentioned this pull request Apr 16, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug player Issues related to any player (main, popup and background)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants