Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase tablet mode breakpoint #6067

Open
3 tasks done
Dakkaron opened this issue Apr 13, 2021 · 0 comments
Open
3 tasks done

Increase tablet mode breakpoint #6067

Dakkaron opened this issue Apr 13, 2021 · 0 comments
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface

Comments

@Dakkaron
Copy link
Contributor

Checklist

Describe the feature you want

Currently, NewPipe determines whether tabled mode should be used based whether the smallest width is <480dp or >=480dp.

According to the the Android developer guide (https://developer.android.com/training/multiscreen/screensizes) the breakpoint should be at 600dp. They have the following quantifiers there:

  • 320dp: a typical phone screen (240x320 ldpi, 320x480 mdpi, 480x800 hdpi, etc).
  • 480dp: a large phone screen ~5" (480x800 mdpi).
  • 600dp: a 7” tablet (600x1024 mdpi).
  • 720dp: a 10” tablet (720x1280 mdpi, 800x1280 mdpi, etc).

This is also consistent with e.g. the Android System UI, which switches into tablet mode at a smallest width of >=600dp.

Is your feature request related to a problem? Please describe it

I run my phone with a smallest width of ~500dp. This defaults NewPipe into tablet mode. PR #6059 fixes the problem for me, but I think the automatic tablet mode threshold is not where it should be.

How will you/everyone benefit from this feature?

This is a really small fix (literally just change a number) and causes phones with larger screens to be detected as phones.
I am pretty sure there is no tablet out there with a (default) smallest width of <600dp.

@Dakkaron Dakkaron added the feature request Issue is related to a feature in the app label Apr 13, 2021
@triallax triallax added the GUI Issue is related to the graphical user interface label Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface
Projects
None yet
Development

No branches or pull requests

2 participants