Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds manual tablet mode setting #6059

Merged
merged 1 commit into from
Jun 15, 2021
Merged

Adds manual tablet mode setting #6059

merged 1 commit into from
Jun 15, 2021

Conversation

Dakkaron
Copy link
Contributor

@Dakkaron Dakkaron commented Apr 12, 2021 •
edited
Loading

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Adds a setting to manually force tablet mode to be on or off under Appearance settings
  • Works as a work-around for tablet-mode related issues like Return to portrait after video finish in fullscreen #5967
  • Also helps all users who increase the minimum width to fit more stuff on their screen, but prefer the better-fitting phone mode for NewPipe

Fixes the following issue(s)

APK testing

https://github.com/TeamNewPipe/NewPipe/suites/2474591406/artifacts/53233850

Due diligence

@triallax triallax self-requested a review April 12, 2021 11:55
@Dakkaron
Copy link
Contributor Author

Dakkaron commented Apr 13, 2021 •
edited
Loading

Is there anything else I need to do/I can help to get this PR merged?

@triallax
Copy link
Contributor

@Dakkaron someone from the team who is actually familiar with Android apps would have to review it and approve it. I'll request reviews from a couple people now.

@triallax triallax requested review from Redirion, AudricV and TobiGr April 13, 2021 10:23
@Dakkaron Dakkaron mentioned this pull request Apr 13, 2021
Open
3 tasks
@AudricV AudricV added feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface labels Apr 19, 2021
triallax
triallax previously approved these changes Jun 13, 2021
View reviewed changes
Copy link
Contributor

@triallax triallax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Waiting on other reviewer(s).

@Dakkaron @AudricV @Stypox
Adds manual tablet mode setting
e01ef42 
Co-authored-by: TiA4f8R <74829229+TiA4f8R@users.noreply.github.com>
@Stypox Stypox force-pushed the manual-tablet-mode-setting branch from 82fdd02 to e01ef42 Compare June 15, 2021 19:45
Stypox
Stypox approved these changes Jun 15, 2021
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you! I added a comment before merging, just so that auto mode is clearer in code.

@Stypox Stypox merged commit d6e0bd8 into TeamNewPipe:dev Jun 15, 2021
This was referenced Jun 26, 2021
Merged
Closed
@SameenAhnaf SameenAhnaf mentioned this pull request Jul 16, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AudricV AudricV AudricV left review comments

@Stypox Stypox Stypox approved these changes

@triallax triallax triallax left review comments

@Redirion Redirion Awaiting requested review from Redirion

@TobiGr TobiGr Awaiting requested review from TobiGr

Assignees
No one assigned
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In Split Screen maximize video
4 participants
@Dakkaron @triallax @Stypox @AudricV