Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enqueueing videos quickly crashes the app in version 0.21.13 #7305

Closed
4 tasks done
estesi opened this issue Oct 24, 2021 · 6 comments · Fixed by #7704
Closed
4 tasks done

Enqueueing videos quickly crashes the app in version 0.21.13 #7305

estesi opened this issue Oct 24, 2021 · 6 comments · Fixed by #7704
Labels
bug Issue is related to a bug waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed.

Comments

@estesi
Copy link

estesi commented Oct 24, 2021

Checklist

Steps to reproduce the bug

  1. Start NewPipe
  2. Long press any video to trigger the actions menu and select "start playing in a popup" or "start playing in the background"
  3. While the first video is still being added to the playback queue and it hasn't started playing (hourglass icon displayed), long press another video or even the same one

Actual behavior

Before the actions menu is triggered for the second video, the app crashes

Expected behavior

I expect to be able to enqueue videos quickly and not wait for the first one to load fully before I can do the former action.

Screenshots/Screen recordings

Logs

Exception

  • User Action: ui error
  • Request: ACRA report
  • Content Country: US
  • Content Language: en
  • App Language: en_US
  • Service: none
  • Version: 0.21.13
  • OS: Linux motorola/potter/potter:8.1.0
Crash log

java.lang.NullPointerException: Attempt to invoke virtual method 'int org.schabi.newpipe.player.playqueue.PlayQueue.size()' on a null object reference
	at org.schabi.newpipe.player.helper.PlayerHolder.getQueueSize(PlayerHolder.java:74)
	at org.schabi.newpipe.local.feed.FeedFragment.showStreamDialog(FeedFragment.kt:331)
	at org.schabi.newpipe.local.feed.FeedFragment.access$showStreamDialog(FeedFragment.kt:80)
	at org.schabi.newpipe.local.feed.FeedFragment$listenerStreamItem$1.onItemLongClick(FeedFragment.kt:390)
	at com.xwray.groupie.GroupieViewHolder$2.onLongClick(GroupieViewHolder.java:32)
	at android.view.View.performLongClickInternal(View.java:6377)
	at android.view.View.performLongClick(View.java:6335)
	at android.view.View.performLongClick(View.java:6353)
	at android.view.View$CheckForLongPress.run(View.java:24762)
	at android.os.Handler.handleCallback(Handler.java:790)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:164)
	at android.app.ActivityThread.main(ActivityThread.java:6626)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:811)


@estesi estesi added the bug Issue is related to a bug label Oct 24, 2021
@estesi
Copy link
Author

estesi commented Oct 24, 2021

I was able to reproduce the crash on a different phone running Android 7.0.

@litetex litetex mentioned this issue Oct 26, 2021
@litetex
Copy link
Member

litetex commented Oct 26, 2021

Also some steps to reproduce from #7310

I have the same error. My steps to reproduce:

  • Open a "What's new" tab
  • Hold a finger on the second from the top video in the list and select "start playing in the background".
  • Not waiting when the video starts playing, hold the finger on the topmost video in the list.
  • App crashes.

@Rigo-V
Copy link

Rigo-V commented Oct 27, 2021

I noticed the same problem on Android 11. I made a screen recording, too. Also sometimes the crash reporting screen won't even appear, the app just silently closes.

Exception

  • User Action: ui error
  • Request: ACRA report
  • Content Country: FI
  • Content Language: fi-FI
  • App Language: fi_FI
  • Service: none
  • Version: 0.21.13
  • OS: Linux Android 11 - 30
Crash log

java.lang.NullPointerException: Attempt to invoke virtual method 'int org.schabi.newpipe.player.playqueue.PlayQueue.size()' on a null object reference
	at org.schabi.newpipe.player.helper.PlayerHolder.getQueueSize(PlayerHolder.java:74)
	at org.schabi.newpipe.fragments.list.BaseListFragment.showStreamDialog(BaseListFragment.java:358)
	at org.schabi.newpipe.fragments.list.BaseListFragment$1.held(BaseListFragment.java:282)
	at org.schabi.newpipe.fragments.list.BaseListFragment$1.held(BaseListFragment.java:274)
	at org.schabi.newpipe.info_list.holder.StreamMiniInfoItemHolder.lambda$enableLongClick$1(StreamMiniInfoItemHolder.java:136)
	at org.schabi.newpipe.info_list.holder.StreamMiniInfoItemHolder.$r8$lambda$mm6ASq2GCzBAsOq1wCHCNeC_Fv4(Unknown Source:0)
	at org.schabi.newpipe.info_list.holder.StreamMiniInfoItemHolder$$ExternalSyntheticLambda1.onLongClick(Unknown Source:4)
	at android.view.View.performLongClickInternal(View.java:7528)
	at android.view.View.performLongClick(View.java:7486)
	at android.view.View.performLongClick(View.java:7504)
	at android.view.View$CheckForLongPress.run(View.java:28263)
	at android.os.Handler.handleCallback(Handler.java:938)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:223)
	at android.app.ActivityThread.main(ActivityThread.java:7664)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)


newpipe_fail.mp4

@Rigo-V
Copy link

Rigo-V commented Oct 27, 2021

As a workaround, I just downgraded to version 0.21.12 as it seems to work fine for me.

@Stypox
Copy link
Member

Stypox commented Jan 25, 2022

Could you test if #7704 solves the issue?

@opusforlife2 opusforlife2 added the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Jan 25, 2022
@github-actions
Copy link

github-actions bot commented Feb 9, 2022

This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please reach out if you have or find the answers we need so that we can investigate further.

@github-actions github-actions bot closed this as completed Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants