Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash after long press #7470

Closed
3 of 4 tasks
Feuerswut opened this issue Nov 30, 2021 · 5 comments
Closed
3 of 4 tasks

Crash after long press #7470

Feuerswut opened this issue Nov 30, 2021 · 5 comments
Labels
bug Issue is related to a bug duplicate Issue or discussion is a duplicate of an existing issue or discussion template ignored The user didn't follow the template/instructions (or removed them)

Comments

@Feuerswut
Copy link

Feuerswut commented Nov 30, 2021

Checklist

Steps to reproduce the bug

  1. Go to Video selection (and have autoplay on click disabled)
  2. Press on the video
  3. Press on play in the bottom right corner
  4. Immediately: long press on another video in the feed
  5. CRASH - null object reference (the queue size has not yet been set by NewPipe.

I'd suggest setting the queue size to 0 or 1 before requesting the video contents and then setting the queue size, just to avoid the bug OR try catching the null object and doing nothing (the user will just be irritated, but the app wont crash)

Actual behavior

The app crashes after long click has been performed

Expected behavior

The app brings up the content (video options) menu for the appropriate video

Screenshots/Screen recordings

Crash Video

Exception

  • User Action: ui error
  • Request: ACRA report
  • Content Country: DE
  • Content Language: de-DE
  • App Language: de
  • Service: none
  • Version: 0.21.13
  • OS: Linux Android 12 - 31
Crash log

java.lang.NullPointerException: Attempt to invoke virtual method 'int org.schabi.newpipe.player.playqueue.PlayQueue.size()' on a null object reference
	at org.schabi.newpipe.player.helper.PlayerHolder.getQueueSize(PlayerHolder.java:74)
	at org.schabi.newpipe.local.feed.FeedFragment.showStreamDialog(FeedFragment.kt:331)
	at org.schabi.newpipe.local.feed.FeedFragment.access$showStreamDialog(FeedFragment.kt:80)
	at org.schabi.newpipe.local.feed.FeedFragment$listenerStreamItem$1.onItemLongClick(FeedFragment.kt:390)
	at com.xwray.groupie.GroupieViewHolder$2.onLongClick(GroupieViewHolder.java:32)
	at android.view.View.performLongClickInternal(View.java:7521)
	at android.view.View.performLongClick(View.java:7479)
	at android.view.View.performLongClick(View.java:7497)
	at android.view.View$CheckForLongPress.run(View.java:28634)
	at android.os.Handler.handleCallback(Handler.java:938)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loopOnce(Looper.java:201)
	at android.os.Looper.loop(Looper.java:288)
	at android.app.ActivityThread.main(ActivityThread.java:7839)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)


Device info

  • Android version: And. 12 Patch Nov. (1), stock
  • Device model: Pixel 6
@Feuerswut Feuerswut added the bug Issue is related to a bug label Nov 30, 2021
@litetex litetex added the template ignored The user didn't follow the template/instructions (or removed them) label Nov 30, 2021
@Feuerswut
Copy link
Author

info: click on the image to open video.

@litetex
Copy link
Member

litetex commented Nov 30, 2021

Duplicate of #7305.
You may give that issue an upvote 😉

Btw: I'm currently waiting for your reply in #7414

@litetex litetex closed this as completed Nov 30, 2021
@litetex litetex added the duplicate Issue or discussion is a duplicate of an existing issue or discussion label Nov 30, 2021
@Stypox
Copy link
Member

Stypox commented Jan 25, 2022

Could you test if #7704 solves the issue?

@litetex
Copy link
Member

litetex commented Jan 25, 2022

@Stypox
Could you please not repost the above line under every duplicated issue of #7305 in the future?
We want to keep the discussion inside #7305.

@Stypox
Copy link
Member

Stypox commented Jan 26, 2022

Sorry, I just wanted to get all users to test, next time I'll ping in the main issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug duplicate Issue or discussion is a duplicate of an existing issue or discussion template ignored The user didn't follow the template/instructions (or removed them)
Projects
None yet
Development

No branches or pull requests

3 participants