Crash on tap and hold in search results while bg queue is loading

[goyalyashpal]

Checklist

• I am using the latest version - 0.21.15 (see this: comment )
  I am using the older version - 0.21.13
• I checked, but didn't find any duplicates (open OR closed) of this issue in the repo.
  gh 🔍 : crash on click and hold search result ; crash on search result
• I have read the contribution guidelines given at CONTRIBUTING.md.
• This issue contains only one bug. I will open one issue for every bug report I want to file.

Steps to reproduce the bug

1. Search for anything
2. Press and hold on any search result
3. Tap on "Start playing in the bg"
4. Quickly repeat step 2, i.e. before the song loads and starts playing
5. Confirmed crash

Screenshots/Screen recordings

video_2022-01-02_11-56-46.mp4

Logs

Exception

• User Action: ui error
• Request: ACRA report
• Content Country: US
• Content Language: en-US
• App Language: en_US
• Service: none
• Version: 0.21.13
• OS: Linux Android 11 - 30

Crash log

java.lang.NullPointerException: Attempt to invoke virtual method 'int org.schabi.newpipe.player.playqueue.PlayQueue.size()' on a null object reference
	at org.schabi.newpipe.player.helper.PlayerHolder.getQueueSize(PlayerHolder.java:74)
	at org.schabi.newpipe.fragments.list.BaseListFragment.showStreamDialog(BaseListFragment.java:358)
	at org.schabi.newpipe.fragments.list.BaseListFragment$1.held(BaseListFragment.java:282)
	at org.schabi.newpipe.fragments.list.BaseListFragment$1.held(BaseListFragment.java:274)
	at org.schabi.newpipe.info_list.holder.StreamMiniInfoItemHolder.lambda$enableLongClick$1(StreamMiniInfoItemHolder.java:136)
	at org.schabi.newpipe.info_list.holder.StreamMiniInfoItemHolder.$r8$lambda$mm6ASq2GCzBAsOq1wCHCNeC_Fv4(Unknown Source:0)
	at org.schabi.newpipe.info_list.holder.StreamMiniInfoItemHolder$$ExternalSyntheticLambda1.onLongClick(Unknown Source:4)
	at android.view.View.performLongClickInternal(View.java:7665)
	at android.view.View.performLongClick(View.java:7623)
	at android.view.View.performLongClick(View.java:7641)
	at android.view.View$CheckForLongPress.run(View.java:28822)
	at android.os.Handler.handleCallback(Handler.java:938)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:261)
	at android.app.ActivityThread.main(ActivityThread.java:8259)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:632)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1049)

---

Device info

• Android version/Custom ROM version: realme UI V2.0
• Device model: realme RMX3381

[goyalyashpal]

Can anyone reproduce this on latest version of newpipe and post their findings?

[BrightDV]

Same bug occurs for me on 0.21.15

Exception

• User Action: ui error
• Request: ACRA report
• Content Country: FR
• Content Language: fr-FR
• App Language: fr_FR
• Service: none
• Version: 0.21.15
• OS: Android 11 - 30

Crash log

java.lang.NullPointerException: Attempt to invoke virtual method 'int org.schabi.newpipe.player.playqueue.PlayQueue.size()' on a null object reference
	at org.schabi.newpipe.player.helper.PlayerHolder.getQueueSize(PlayerHolder.java:74)
	at org.schabi.newpipe.fragments.list.BaseListFragment.showStreamDialog(BaseListFragment.java:358)
	at org.schabi.newpipe.fragments.list.BaseListFragment$1.held(BaseListFragment.java:282)
	at org.schabi.newpipe.fragments.list.BaseListFragment$1.held(BaseListFragment.java:274)
	at org.schabi.newpipe.info_list.holder.StreamMiniInfoItemHolder.lambda$enableLongClick$1(StreamMiniInfoItemHolder.java:136)
	at org.schabi.newpipe.info_list.holder.StreamMiniInfoItemHolder.$r8$lambda$mm6ASq2GCzBAsOq1wCHCNeC_Fv4(Unknown Source:0)
	at org.schabi.newpipe.info_list.holder.StreamMiniInfoItemHolder$$ExternalSyntheticLambda1.onLongClick(Unknown Source:4)
	at android.view.View.performLongClickInternal(View.java:8240)
	at android.view.View.performLongClick(View.java:8198)
	at android.view.View.performLongClick(View.java:8216)
	at android.view.View$CheckForLongPress.run(View.java:30194)
	at android.os.Handler.handleCallback(Handler.java:938)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:246)
	at android.app.ActivityThread.main(ActivityThread.java:8633)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:602)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1130)

---

[Stypox]

Could you test if #7704 solves the issue?

[goyalyashpal]

Could you test if #7704 solves the issue?

hey so, i tested that.

• it didnt crash, but
• it didnt enqueue either.
• What more, it deceptively showed the toast "Enqueued"
• so... i will not consider the issue to be fixed, the issue just became less severe
• the false showing of enqueued toast is something bad

[Stypox]

What more, it deceptively showed the toast "Enqueued"

You are right, I'm going to fix this, thank you for the feedback. Up until the play queue is ready it's not possible to do any action with the player, so I'll just consider the player as closed when that's the case and show the stream dialog with the closed-player-entries.

[goyalyashpal]

so I'll just consider the player as closed when that's the case

i know that's a very stupid question of mine, but can the player & queue starting logic be improved - at least surfacially. say like

• making the player with empty queue ready before hand, or like
• shifting the logic so that the time consuming part can be put later

is this a relatively new problem that player takes so long to start, or was it this way from starting?

[Stypox]

I completely agree with you, and there is a separate issue exactly for that: #7673 :-)

[badsha000000]

Hi Yashpalgoyal1304,
Are you using Realme8s 5g??
Did you unlock your bootloader ?

I am realme 8s (RMS3381) user. On this device Realme UI if fully filled with bugs and some other problems. I just want to change my rom. Can you help me?

U want to unlock bootloader and root my device.

No in-depth apk works