Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated methods that fetch full info for sparse streams #7941

Closed
5 tasks done
Stypox opened this issue Feb 24, 2022 · 0 comments · Fixed by #7981
Closed
5 tasks done

Duplicated methods that fetch full info for sparse streams #7941

Stypox opened this issue Feb 24, 2022 · 0 comments · Fixed by #7981
Labels
codequality Improvements to the codebase to improve the code quality

Comments

@Stypox
Copy link
Member

Stypox commented Feb 24, 2022

Checklist

  • This issue contains only one bug.
  • I am able to reproduce the bug with the latest version.
  • I have read and understood the contribution guidelines.
  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.

Affected version

After (but also before) #7570

The problem

There are currently two methods which do almost the same thing: StreamDialogEntry.fetchItemInfoIfSparse() and SaveUploaderUrlHelper.saveUploaderUrlIfNeeded(). They both return some information from the info item if it is available right away (though using different checks, which is inconsistent), or fetch the full stream info if the info item was sparse. They should be deduplicated. See #7570 (comment)

@Stypox Stypox added bug Issue is related to a bug codequality Improvements to the codebase to improve the code quality and removed bug Issue is related to a bug labels Feb 24, 2022
Stypox added a commit to Stypox/NewPipe that referenced this issue Mar 3, 2022
Stypox added a commit to Stypox/NewPipe that referenced this issue Mar 3, 2022
Stypox added a commit to Stypox/NewPipe that referenced this issue Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codequality Improvements to the codebase to improve the code quality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant