Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications of the same videos keep being generated #8684

Open
5 tasks done
Kroesss opened this issue Jul 23, 2022 · 31 comments
Open
5 tasks done

Notifications of the same videos keep being generated #8684

Kroesss opened this issue Jul 23, 2022 · 31 comments
Labels
bug Issue is related to a bug feed Issue is related to the feed new stream notification Feature: notification shown for new videos

Comments

@Kroesss
Copy link

Kroesss commented Jul 23, 2022

Checklist

  • I am able to reproduce the bug with the latest version.
  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected version

0.23.1

Steps to reproduce the bug

  1. Dismiss notification of video from subscribed channel
  2. Mark the video as watched
  3. Receive notifications of the same video over and over again.

Expected behavior

I expect just 1 notification of a new video from a subscribed channel. This should not return after it has been dismissed.

Actual behavior

I keep getting notifications of the same videos for months. I have marked them as watched, I have swiped the notifications away and I have tapped the notifications multiple times. A couple times per week I get the same notifications back.

Screenshots/Screen recordings

No response

Logs

No response

Affected Android/Custom ROM version

Android 11 (stock OEM-version of OnePlus)

Affected device model

OnePlus Nord2 5G

Additional information

No response

@Kroesss Kroesss added the bug Issue is related to a bug label Jul 23, 2022
@opusforlife2 opusforlife2 added the feed Issue is related to the feed label Jul 25, 2022
@daykx
Copy link

daykx commented Aug 19, 2022

Maybe it's related: after downloading a video and dismissing notification about downloading it, sometimes download notification repeats several hours later.

@theg721
Copy link

theg721 commented Apr 12, 2023

I've had the same issue for a while now. One thing I've noticed is that there are specific channels this happens with. It doesn't happen for most of the channels I'm subscribed to, but for example both Tom Scott and Tom Scott Plus seem to consistently have this issue.

I think marking the latest video watched is irrelevant as I've had this both on videos I have watched and videos I haven't watched.

@paulverbeke
Copy link

It's been happening to me for a while too.
Now for every new push I receive 20+ that I need to swipe away.
OnePlus 8T stock OS Android 13
OnePlus 8T Pixel Experience Android 13
Newpipe 0.26.0

@TobiGr
Copy link
Contributor

TobiGr commented Dec 27, 2023

Uh, I thought that this was fixed by #10494. Please export your database via settings > content > export database and send it to team{at]newpipe.net. I do not have much time now, so I cannot promise a deep analysis - maybe it's an obvious bug when looking at the data. Please also name the videos / channels that are effected by the bug in the email.

@paulverbeke
Copy link

Ok thanks I'll send you all this by mail as soon as it happen's again

@opusforlife2 opusforlife2 added the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Dec 27, 2023
@paulverbeke
Copy link

paulverbeke commented Dec 28, 2023

All right just sent you an email with 2 screenshots, the exported database, and name of channels and links of videos for easier testing. I can see that all the videos I checked were from 3 months ago. I think it's always these same videos that are pushed again to me in a loop

@paulverbeke
Copy link

paulverbeke commented Dec 29, 2023

Just received your answer by mail.

You said you've done this to reproduce unsuccessfully:

  • Install NewPipe 0.26.1
  • Import your database (backup from the 28th)
  • (Tons of notifications appear)
  • Close new notifications
  • wait for new notifications
  • only three channels show up with videos from within the last hour

I don't know what else to say. NewPipe is 0.26.1 but it just happened to me again this morning (but only with some videos not all of them).
Just in case, I made a new backup (on the 29th), cleared app data to reset the app, and made some tests:
Re-importing the db of the 28th --> I receive 4 push.
Re-importing the db of the 29th --> I don't receive any push. So maybe you're right, the old videos may have finally been cleared from the db.

Thanks for the investigation, will let you posted here

@Kroesss
Copy link
Author

Kroesss commented Dec 29, 2023

Same here. I am also on 0.26.1, and got notifications of old video's this morning.

@github-actions github-actions bot removed the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Dec 29, 2023
@opusforlife2
Copy link
Collaborator

So maybe you're right, the old videos may have finally been cleared from the db.

Let's wait a little longer to confirm this.

@opusforlife2 opusforlife2 added the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Dec 29, 2023
@rx78gp01
Copy link

I also got notifications of old video that video's upload date between 3 and 4 months ago.
It seems that NewPipeExtractor extract wrong video's upload date between 3 and 4 months ago,
newpipe show textual date 2 months ago in feed.

@paulverbeke
Copy link

paulverbeke commented Jan 2, 2024

So maybe you're right, the old videos may have finally been cleared from the db.

Let's wait a little longer to confirm this.

Just received this push the 2nd of January https://www.youtube.com/watch?v=cBpGq-vDr2Y. Released 29th sept 2023

And received this one (https://www.youtube.com/watch?v=xILlbJzwuRc) the 3rd of January, released 3rd October 2023.

@opusforlife2 opusforlife2 removed the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Jan 2, 2024
@Kroesss
Copy link
Author

Kroesss commented Apr 24, 2024

Is this bug still being worked on? To be honest, it is becoming rather annoying getting 10 notifications every day about old video's

@opusforlife2
Copy link
Collaborator

Someone will have to investigate this more deeply. It doesn't happen to any of the team members so it's hard to debug.

As an experiment, you could try this:

  1. Export your database so you have a backup when you're done testing. (Or you could use a Release Candidate APK from the pinned issue right now so your main app isn't disturbed.)
  2. Export your subscriptions from the Subscriptions tab.
  3. Clear Newpipe data from App Info.
  4. Open Newpipe and import only Subscriptions.
  5. Set up your notifications how you want them.
  6. See if the problem occurs again.

If it doesn't, that would mean your database got corrupted somehow.

@opusforlife2 opusforlife2 added the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Apr 24, 2024
@Kroesss
Copy link
Author

Kroesss commented Apr 24, 2024

Is there some kind of log or anything that I should capture first, just in case?

I did install the new update today, so I am on 0.27 now

@github-actions github-actions bot removed the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Apr 24, 2024
@opusforlife2
Copy link
Collaborator

If the steps above work, we can at least narrow it down to a database corruption. Try that first.

@opusforlife2 opusforlife2 added the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Apr 24, 2024
@github-actions github-actions bot removed the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Apr 27, 2024
@Kroesss
Copy link
Author

Kroesss commented Apr 27, 2024

@opusforlife2 I've done the steps you indicated yesterday, and woke up to old notifications today sadly.

What is the best thing for me to do now?

@paulverbeke
Copy link

@opusforlife2 It still happens to me, I'll try the experiment you suggested.

@opusforlife2
Copy link
Collaborator

@Kroesss What happened when you tried the steps? Did the problem occur?

@Kroesss
Copy link
Author

Kroesss commented Apr 29, 2024

@opusforlife2 Yes. Sorry, now that I re-read my comment it is a bit vague.

I did the steps you mentioned, and the next morning when I woke up, I had 10 notifications of old video's. I got them again this morning by the way, so the behaviour is consistent.

As mentioned, I am running 0.27, so the latest version.

@opusforlife2
Copy link
Collaborator

If @paulverbeke gets the same results, then it's likely not a database corruption but something else. Let's see.

@opusforlife2 opusforlife2 added the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Apr 29, 2024
@paulverbeke
Copy link

Could it be possible that importing the database fixes it, but gets corrupted again over time ?

@paulverbeke
Copy link

paulverbeke commented May 1, 2024

All right, done the same thing you instructed and received 6 push today, all from the 1st may. So looks like it's working.

@opusforlife2
Copy link
Collaborator

Let's wait for a while to see if the behaviour is consistent.

@opusforlife2 opusforlife2 added waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. and removed waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. labels May 2, 2024
@Kroesss
Copy link
Author

Kroesss commented May 3, 2024

For what it is worth, I got the old notifications again today. No changes in settings.

@github-actions github-actions bot removed the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label May 3, 2024
@opusforlife2
Copy link
Collaborator

Could you try the exact steps once more, @Kroesss? The fact that you're both getting different results via the same steps is pointing towards different problems. Paul's might be a corrupt database after all, and yours might be something else. So let's confirm once more.

@opusforlife2 opusforlife2 added the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label May 5, 2024
@paulverbeke
Copy link

Since yesterday the bug occurs again sorry 😔

@opusforlife2
Copy link
Collaborator

Welp. Then it's something else, not a corrupt database.

@opusforlife2 opusforlife2 added new stream notification Feature: notification shown for new videos and removed waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. labels May 5, 2024
@Kroesss
Copy link
Author

Kroesss commented May 6, 2024

If I can help by supplying logs or test something, just let me know.

@sivaraam
Copy link

For the note, I also followed the steps listed here and was able to still observe the redundant notifications issue.

@shadowcyberdeck
Copy link

shadowcyberdeck commented Jan 2, 2025

Having this same issue on my device. I tried the steps mentioned for exporting and importing just the settings, but still get notifications for both old videos and older live streams. Also not sure if its related, but I get multiple notifications for the same video everytime NewPipe checks for new videos.

I sometimes, not always, get notifications for older videos that I've marked as watched

For some reason the notifications for me at least appear to pick up videos that are 2-3 months old that I didn't mark as watched. There are newer videos most of which have already been marked as watched, and no new videos were posted at the time of newpipe checking.

Not sure this matters but my subscription list is around 300 channels, with notifications enabled for around 190 of them.

NewPipe Version: 0.27.4
Phone: Pixel 9 Pro XL
Android Version: 15

@Candlemass
Copy link

Candlemass commented Jan 15, 2025

Still a problem 6 months later on version 0.27.4.

I love getting spammed once a day with mutiple push notifications containing 20-40 old videos.

It's such a great user experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug feed Issue is related to the feed new stream notification Feature: notification shown for new videos
Projects
None yet
Development

No branches or pull requests

10 participants