Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash after feed update #10229

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Conversation

Koitharu
Copy link
Contributor

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Fixed a crash after updating the feed. It doesn't seem to be a common issue, however it happens every time on my device.

Before/After Screenshots/Screen Record

Not needed

Fixes the following issue(s)

Relies on the following changes

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@TobiGr TobiGr added bug Issue is related to a bug feed Issue is related to the feed labels Jul 14, 2023
@TobiGr TobiGr self-assigned this Jul 14, 2023
Copy link
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome back! It's good to hear from you, I hope you are doing well.

The code change look good and fixes the crash for me. Thank you.

@TobiGr TobiGr merged commit 8cfba40 into TeamNewPipe:dev Jul 14, 2023
@Stypox
Copy link
Member

Stypox commented Jul 14, 2023

This was actually already fixed in the channel tabs PR, but yeah, good idea to separate it here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug feed Issue is related to the feed
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[nightly] Feed refresh fails - Null param FeedLoadService
3 participants