Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LeakCanary crash #10231

Closed
wants to merge 1 commit into from

Conversation

TacoTheDank
Copy link
Member

@TacoTheDank TacoTheDank commented Jul 14, 2023

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@TacoTheDank TacoTheDank mentioned this pull request Jul 14, 2023
5 tasks
@TacoTheDank TacoTheDank requested a review from TobiGr July 14, 2023 17:02
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@TacoTheDank
Copy link
Member Author

I'm trying to view the "1 vulnerability" Snyk is reporting, but I'm getting this:

image

@Stypox
Copy link
Member

Stypox commented Jul 14, 2023

Don't worry about the vulnerability, it's unrelated. Also, why do you think we should not use the default setup and call it a day?

@Stypox
Copy link
Member

Stypox commented Jul 14, 2023

What do you think about #10232?

@TacoTheDank
Copy link
Member Author

TacoTheDank commented Jul 15, 2023

I figured we would keep the manual install because of retainedDelayMillis, but I guess that's fine. Let's do yours instead if it works.

@TacoTheDank TacoTheDank deleted the fixLeakCanaryCrash branch July 18, 2023 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants