Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PrettyTime to 5.0.8 #11094

Merged

Conversation

moontoaster
Copy link
Contributor

@moontoaster moontoaster commented May 23, 2024

This version contains a fix for Ukrainian locale which fixes #11092.

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Update PrettyTime to from 5.0.7 to 5.0.8

Before/After Screenshots/Screen Record

  • Before:
    newpipe before
  • After:
    newpipe after

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

This version contains a fix for Ukrainian locale which fixes TeamNewPipe#11092.
@github-actions github-actions bot added the size/small PRs with less than 50 changed lines label May 23, 2024
@TobiGr TobiGr added bug Issue is related to a bug localisation / translation Everything that has to do with translations or Weblate dependency Issues and PRs related to dependencies labels May 23, 2024
Copy link
Member

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link

sonarcloud bot commented May 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@TobiGr TobiGr merged commit 8645618 into TeamNewPipe:dev May 23, 2024
6 of 9 checks passed
@Stypox Stypox mentioned this pull request Nov 17, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug dependency Issues and PRs related to dependencies localisation / translation Everything that has to do with translations or Weblate size/small PRs with less than 50 changed lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upload dates have a minus prepended if they're in the past and language is set to Ukrainian
2 participants